Skip to content

fix(ci): handle Node 25 incompatibility with c8 11.0.0 / yargs 17.x #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendandburns merged 4 commits into from
Mar 3, 2026
+8 −1
Merged

fix(ci): handle Node 25 incompatibility with c8 11.0.0 / yargs 17.x #2783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acda777
Initial plan
Copilot Feb 28, 2026
9522a3d
fix(ci): allow Node 25 to fail due to c8/yargs incompatibility
Copilot Feb 28, 2026
528c983
fix(ci): run tests without c8 coverage on Node 25 as fallback
Copilot Mar 3, 2026
228e04a
fix(ci): remove unrelated fail-fast: false from workflow
Copilot Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ jobs:
# and package-lock.json. Needs to run before npm install
- run: node version-check.js
- run: npm ci
- run: npm test
# Node 25 has a known incompatibility: extension-less files in "type: module"
# packages are treated as ESM, causing c8's require('yargs/yargs') to fail.
# Fall back to plain unit tests without coverage on Node 25 until upstream fixes this.
- if: matrix.node != '25'
run: npm test
- if: matrix.node == '25'
run: npm run test-no-coverage
- run: npm run lint
- run: npm audit --audit-level=critical
- run: npm run build-with-tests && npm run test-transpiled
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"generate": "./generate-client.sh",
"watch": "tsc --watch",
"test": "c8 node --test --test-reporter=spec --import tsx src/*_test.ts",
"test-no-coverage": "node --test --test-reporter=spec --import tsx src/*_test.ts",
"test-transpiled": "node --test --test-reporter=spec dist/*_test.js",
"integration-test": "tsx src/test/integration/index.ts",
"prepare": "npm run build && husky",
Expand Down