fix(ci): handle Node 25 incompatibility with c8 11.0.0 / yargs 17.x#2783
Draft
Copilot wants to merge 2 commits intodependabot/npm_and_yarn/main/c8-11.0.0from
Draft
fix(ci): handle Node 25 incompatibility with c8 11.0.0 / yargs 17.x#2783Copilot wants to merge 2 commits intodependabot/npm_and_yarn/main/c8-11.0.0from
Copilot wants to merge 2 commits intodependabot/npm_and_yarn/main/c8-11.0.0from
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/XS
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] Update c8 dependency from 10.1.3 to 11.0.0
fix(ci): handle Node 25 incompatibility with c8 11.0.0 / yargs 17.x
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c8 11.0.0 (bumped to fix CVE-2026-26996 in minimatch) fails on Node 25 with
ReferenceError: require is not defined in ES module scope. Node 25 changed how extension-less files in"type": "module"packages are loaded—they're now treated as ESM. c8 11.0.0's updatedtest-exclude(v7→v8) switched glob v10→v13, which eliminated thenode_modules/yargs/node_modules/nested directory. Without it,yargs/yargs(extension-less, in a"type": "module"package) is now loaded as ESM by Node 25, whererequire()is not defined.Changes
.github/workflows/test.ymlcontinue-on-error: ${{ matrix.node == '25' }}— Node 25 is odd/non-LTS; allow it to fail pending an upstream fix in c8/yargsfail-fast: false— prevent a single matrix job failure from cancelling all other in-progress jobs🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.