feat: use knative.dev/pkg/tls for queue-proxy TLS configuration#16425
Open
Fedosin wants to merge 1 commit intoknative:mainfrom
Open
feat: use knative.dev/pkg/tls for queue-proxy TLS configuration#16425Fedosin wants to merge 1 commit intoknative:mainfrom
Fedosin wants to merge 1 commit intoknative:mainfrom
Conversation
knative-prow
bot
added
the
size/L
Fedosin
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16425 +/- ##
==========================================
+ Coverage 80.21% 80.27% +0.05%
==========================================
Files 217 217
Lines 13511 13528 +17
==========================================
+ Hits 10838 10859 +21
+ Misses 2307 2302 -5
- Partials 366 367 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
linkvt
reviewed
Mar 3, 2026
twoGiants
approved these changes
Mar 4, 2026
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Very clean, great job, thank you! 😺 👍
/approve
/lgtm
|
/retest |
Contributor
Author
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
linkvt
reviewed
Mar 5, 2026
Replace the hardcoded tls.VersionTLS13 in queue-proxy's TLS server with the shared knative.dev/pkg/tls package, allowing TLS settings to be configured via QUEUE_PROXY_TLS_MIN_VERSION, QUEUE_PROXY_TLS_MAX_VERSION, QUEUE_PROXY_TLS_CIPHER_SUITES, and QUEUE_PROXY_TLS_CURVE_PREFERENCES environment variables. The default remains TLS 1.3 when no env var is set. Add four new keys to the config-deployment ConfigMap (queue-sidecar-tls-min-version, queue-sidecar-tls-max-version, queue-sidecar-tls-cipher-suites, queue-sidecar-tls-curve-preferences) and forward them as QUEUE_PROXY_TLS_* environment variables in makeQueueContainer. This allows cluster admins to configure the queue-proxy's TLS server via the same ConfigMap used for other queue-proxy settings (like queue-sidecar-rootca), since the operator cannot inject env vars into the dynamically created sidecar via manifestival. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin, twoGiants The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replace the hardcoded
tls.VersionTLS13in queue-proxy's TLS server with the sharedknative.dev/pkg/tlspackage, allowing TLS settings to be configured viaQUEUE_PROXY_TLS_MIN_VERSION,QUEUE_PROXY_TLS_MAX_VERSION,QUEUE_PROXY_TLS_CIPHER_SUITES, andQUEUE_PROXY_TLS_CURVE_PREFERENCESenvironment variables. The default remainsTLS 1.3when no env var is set.Add four new keys to the config-deployment ConfigMap (
queue-sidecar-tls-min-version,queue-sidecar-tls-max-version,queue-sidecar-tls-cipher-suites,queue-sidecar-tls-curve-preferences) and forward them asQUEUE_PROXY_TLS_*environment variables inmakeQueueContainer. This allows cluster admins to configure the queue-proxy's TLS server via the same ConfigMap used for other queue-proxy settings (likequeue-sidecar-rootca), since the operator cannot inject env vars into the dynamically created sidecar via manifestival.Release Note
knative/pkg patch: knative/pkg#3324