feat: use knative.dev/pkg/tls for activator TLS configuration#16424
Open
Fedosin wants to merge 1 commit intoknative:mainfrom
Open
feat: use knative.dev/pkg/tls for activator TLS configuration#16424Fedosin wants to merge 1 commit intoknative:mainfrom
Fedosin wants to merge 1 commit intoknative:mainfrom
Conversation
knative-prow
bot
added
the
size/S
knative-prow
bot
added
size/L
Contributor
|
Looks good! /lgtm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16424 +/- ##
==========================================
+ Coverage 80.21% 80.27% +0.05%
==========================================
Files 217 217
Lines 13511 13511
==========================================
+ Hits 10838 10846 +8
+ Misses 2307 2301 -6
+ Partials 366 364 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
linkvt
reviewed
Mar 3, 2026
twoGiants
reviewed
Mar 3, 2026
twoGiants
reviewed
Mar 3, 2026
twoGiants
approved these changes
Mar 3, 2026
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
/approve
Left a few comments, but nothing major and probably can be merged anyway. Wdys?
|
/hold for the comment review Unhold when you want to merge @Fedosin |
knative-prow
bot
added
the
do-not-merge/hold
knative-prow
bot
added
size/M
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Contributor
Author
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
knative-prow
bot
added
size/L
knative-prow
bot
added
size/M
Contributor
Author
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
linkvt
reviewed
Mar 5, 2026
Replace the hardcoded tls.VersionTLS13 in the activator's HTTPS server with the shared knative.dev/pkg/tls package, allowing TLS settings to be configured via ACTIVATOR_TLS_MIN_VERSION, ACTIVATOR_TLS_MAX_VERSION, ACTIVATOR_TLS_CIPHER_SUITES, and ACTIVATOR_TLS_CURVE_PREFERENCES environment variables. The default remains TLS 1.3 when no env var is set. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
knative-prow
bot
added
size/S
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin, twoGiants The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replace the hardcoded tls.VersionTLS13 in the activator's HTTPS server with the shared knative.dev/pkg/tls package, allowing TLS settings to be configured via ACTIVATOR_TLS_MIN_VERSION, ACTIVATOR_TLS_MAX_VERSION, ACTIVATOR_TLS_CIPHER_SUITES, and ACTIVATOR_TLS_CURVE_PREFERENCES environment variables. The default remains TLS 1.3 when no env var is set.
knative/pkg patch: knative/pkg#3324
Release Note