Skip to content

test: pin func CLI version so config CI workflow test is deterministic #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Sep 1, 2026
Merged

test: pin func CLI version so config CI workflow test is deterministic #4034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/config_ci_int_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"knative.dev/func/pkg/ci/github"
fn "knative.dev/func/pkg/functions"
fnTest "knative.dev/func/pkg/testing"
"knative.dev/func/pkg/version"
)

// START: Integration Tests
Expand Down Expand Up @@ -77,6 +78,13 @@ func TestNewConfigCICmd_CreatesGitHubWorkflowDirectory(t *testing.T) {
}

func TestNewConfigCICmd_WritesWorkflowFileToFSWithCorrectYAMLStructure(t *testing.T) {
// Pin the CLI version so the generated workflow is deterministic,
// independent of the version injected via -ldflags at build time
// (which varies with the branch's most recent git tag).
prev := version.Kver
version.Kver = github.DefaultFuncCliVersion
t.Cleanup(func() { version.Kver = prev })

opts := defaultIntegrationOpts(t, nil)

err := runConfigCiCmdIntegration(t, opts)
Expand Down
Loading