test: pin func CLI version so config CI workflow test is deterministic - #4034
Conversation
The integration test asserted the generated workflow contains github.DefaultFuncCliVersion, but the command now sources the version from version.Kver (injected via -ldflags). On release-1.23 the branch's latest tag is knative-v1.23.1, so the emitted version did not match the compiled-in default (knative-v1.23.0) and the test failed. Pin version.Kver in the test so the output is independent of the build/branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
knative-prow
Bot
added
the
size/XS
|
Hi @pmeida. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
the
needs-ok-to-test
|
/assign @matejvasek |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, pmeida The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
2 participants
Changes
version.Kverin the config CI integration test so the generated workflow's func CLI version is independent of the build environment and branch tags/kind cleanup
Relates to #4029
Release Note
Docs