Repository navigation
rootfs: add missing LTP build and runtime dependencies #3246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,8 +71,14 @@ actions: | |
| description: Install cross-build target dependencies | ||
| recommends: false | ||
| packages: | ||
| - libacl1-dev | ||
| - libaio-dev | ||
| - libc6-dev | ||
| - libcap-dev | ||
| - libmnl-dev | ||
| - libnuma-dev | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. but leave it here, the changelog says we should be removing it?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. The changelog should make the two stages clearer. I’ll update this in the changelog libnuma-dev remains a build dependency because LTP needs its headers during compilation. The recipe already removes it afterward; previously, extra_packages installed it again into the finished image. This patch removes that reinstallation and provides the runtime library and NUMA command-line tools instead. |
||
| - libssl-dev | ||
| - libtirpc-dev | ||
| {{ end }} | ||
|
|
||
| - action: run | ||
|
|
@@ -89,7 +95,11 @@ actions: | |
| - action: run | ||
| description: Remove cross-build target dependencies | ||
| chroot: true | ||
| command: apt-get autoremove --purge -y libc6-dev libnuma-dev && apt-get clean | ||
| command: >- | ||
| apt-get autoremove --purge -y | ||
| libacl1-dev libaio-dev libc6-dev libcap-dev | ||
| libmnl-dev libnuma-dev libssl-dev libtirpc-dev | ||
| && apt-get clean | ||
| {{ end }} | ||
|
|
||
| - action: run | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We remove libnuma-dev from the list to be installed (but add numactl and libnuma1) here.