Repository navigation
Conversation
Install target development libraries before configuring LTP so optional tests are built instead of dependency-skip stubs. Remove build-only packages after compilation and include the runtime libraries, compiler, headers and tools required by installed tests. Replace runtime libnuma-dev with libnuma1 and explicitly install libc6-dev because package recommendations are disabled. Signed-off-by: Aishwarya TCV <aishwarya.tcv@arm.com>
broonie
left a comment
broonie
left a comment
There was a problem hiding this comment.
This may just be me asking for a clearer changelog...
| - iproute2 | ||
| - iputils-ping | ||
| - jq | ||
| - libnuma-dev |
There was a problem hiding this comment.
We remove libnuma-dev from the list to be installed (but add numactl and libnuma1) here.
| - libc6-dev | ||
| - libcap-dev | ||
| - libmnl-dev | ||
| - libnuma-dev |
There was a problem hiding this comment.
but leave it here, the changelog says we should be removing it?
There was a problem hiding this comment.
Thanks. The changelog should make the two stages clearer. I’ll update this in the changelog
libnuma-dev remains a build dependency because LTP needs its headers during compilation. The recipe already removes it afterward; previously, extra_packages installed it again into the finished image. This patch removes that reinstallation and provides the runtime library and NUMA command-line tools instead.
This branch has not been deployed
2 participants
Install missing target development libraries before configuring LTP so
optional tests are built instead of dependency-skip stubs. Remove these
build dependencies after compilation.
Retain libnuma-dev in the pre-build dependency list because its headers
are required to compile NUMA-enabled tests. The recipe already removes
it after compilation. Drop it only from the post-build extra_packages
list, which previously reinstalled it into the finished image, and
provide libnuma1 and numactl for runtime NUMA coverage instead.
Include the runtime libraries, compiler and tools required by installed
tests. Explicitly install libc6-dev for tests that compile fixtures,
because package recommendations are disabled.