Skip to content

fix: convert artist credit rows to flexboxes to handle rtl correctly#233

Open
arsinclair wants to merge 1 commit into
kellnerd:mainfrom
arsinclair:fix/rtl-text
Open

fix: convert artist credit rows to flexboxes to handle rtl correctly#233
arsinclair wants to merge 1 commit into
kellnerd:mainfrom
arsinclair:fix/rtl-text

Conversation

@arsinclair

@arsinclair arsinclair commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@kellnerd kellnerd added bug Something isn't working web Web interface labels Jun 24, 2026

@kellnerd kellnerd left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting, I am not even sure if the previous behavior is some kind of bug in the rendering engine... thank you for reporting @YoGo9!

You are right @arsinclair, in order to keep the entity name as link without this weird glitch, flex-boxes seem to be the proper solution as far as I can see.
However, the list items of the alternative values can't be flex-boxes themselves, with this change they lose their bullet points. We probably need an additional container to achieve the desired outcome.
Also, the same issue potentially affects all entity links, so the CSS changes should target those and not just artist credits.

@arsinclair

arsinclair commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Awesome, then I hope maybe @YoGo9 or @kellnerd can take it forward from here? My PR was just a scratchpad example to show what I mean, neither did I test it well nor have I verified this issue in other areas of the app :) I'd be glad to complete the implementation, but unfortunately I'm very short on time right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working web Web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants