Fix RTL artists link rendering #229
Closed
YoGo9 wants to merge 2 commits into
Closed
Conversation
Fix formatting of MusicBrainz link and icon display for RTL languages
Contributor
|
Hmm, but that seems intentional to me. Clicking on the artist name should open it in MusicBrainz. It is probably necessary to guess the artist name script and insert RTL/LTR marks where necessary rather than moving the artist text away from the link. |
Contributor
|
Actually I found a better way. Just convert the containers to flexboxes and it will be handled automatically. Please take a look at #233. |
Author
|
Thank you! I will test it tomorrow locally. |
Author
|
Just tested #233 Works great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested it on my instance the artists icons are rendered properly.
https://harmony.mybrainz.dev/release?url=https%3A%2F%2Fopen.spotify.com%2Falbum%2F109QLZlDgbLiC1b0P7nJo7&category=preferred
Instead of the current rendering which causes confusion when clicking artist links.
https://harmony.pulsewidth.org.uk/release?url=https%3A%2F%2Ftidal.com%2Falbum%2F529736650>in=®ion=GB%2CUS%2CDE%2CJP&musicbrainz=&deezer=&itunes=&spotify=&tidal=&qobuz=&beatport=