Skip to content

Preserve signed archive evidence during static projection - #9

Merged
johnsonlee merged 1 commit into
mainfrom
fix/signed-mr-projection
Nov 15, 2026
Merged

johnsonlee merged 1 commit into
mainfrom
fix/signed-mr-projection

Conversation

@johnsonlee

@johnsonlee johnsonlee commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Preparing a signed multi-release dependency such as Bouncy Castle 1.78 fails with a signature digest error: build-JDK selection replaces root class bytes, but the next normalization step treats the inventory projection and its original signatures as an authenticated JAR.

Graph normalization now reads the original archive and omits stale signing blocks only when writing transformed analysis copies. Inventory preserves the original manifest and signature bytes alongside the selected class contents. Original archive verification stays enabled, and an unchanged ordinary signed JAR remains unchanged.

Validation:

  • 295 input/preparation tests pass, including real JDK-signed JAR, Spring Boot JAR and WAR fixtures, build-JDK selection, preserved inventory evidence, and rejection of tampered signed input.
  • Production and test lint pass; all four affected production files have 100% line and branch coverage.
  • The real Bouncy Castle dependency projects successfully: all 4,257 graph entries can be read through a verifying JarFile, the selected class bytes match the build-JDK view, and original signing metadata and archive bytes remain intact.

All 13 checks in the full Build workflow pass on this commit, including Ubuntu/macOS test shards and aggregate coverage/lint gates. Packaged dependency ordering is addressed separately in #10.

@github-actions

Copy link
Copy Markdown

Unit test coverage: Passed

Commit 36dc6e77cce190cd8c927d1e4f1daf0e8f4df1fa · Build run 43599106620, attempt 1

Required for every module on both platforms: 100% line and 100% branch coverage. A pass requires zero missed lines/branches and nonzero measured totals.

Platform Verification
ubuntu-latest Passed
macos-latest Passed
Module Platform Line Branch
engine ubuntu-latest 100% (5993/5993) 100% (5969/5969)
engine macos-latest 100% (5993/5993) 100% (5969/5969)
gfc ubuntu-latest 100% (479/479) 100% (368/368)
gfc macos-latest 100% (479/479) 100% (368/368)
plugin/gradle ubuntu-latest 100% (172/172) 100% (76/76)
plugin/gradle macos-latest 100% (172/172) 100% (76/76)
plugin/maven ubuntu-latest 100% (108/108) 100% (90/90)
plugin/maven macos-latest 100% (108/108) 100% (90/90)

Coverage reports describe this run; missing or invalid reports never count as 100%. The required run-unit-test check also requires all tests and verification steps to succeed.

@johnsonlee
johnsonlee marked this pull request as ready for review November 14, 2026 14:45
@johnsonlee
johnsonlee merged commit c137ba2 into main Nov 15, 2026
13 checks passed
@johnsonlee
johnsonlee deleted the fix/signed-mr-projection branch November 15, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant