Repository navigation
Honor declared classpath order in static inputs - #10
Merged
Merged
Conversation
johnsonlee
commented
Nov 14, 2026
johnsonlee
left a comment
Owner
Author
There was a problem hiding this comment.
One issue in the ordering source for Maven flat scopes (inline).
The rest checks out:
- Boot uses
BOOT-INF/classesfollowed by a completeclasspath.idx, and an incomplete index falls back to unambiguous selection. - WAR stays unambiguous.
- Shadowed definitions stay in the inventory, and the paired goldens make their changes obligations.
- The cache key includes the selection policy.
Generated by Claude Code
johnsonlee
force-pushed
the
fix/signed-mr-projection
branch
from
November 14, 2026 13:18
b42c5f9 to
36dc6e7
Compare
johnsonlee
force-pushed
the
fix/static-classpath-order
branch
3 times, most recently
from
November 14, 2026 13:47
c8456ab to
2d842be
Compare
johnsonlee
force-pushed
the
fix/static-classpath-order
branch
from
November 14, 2026 14:41
2d842be to
8f8fa60
Compare
Unit test coverage: PassedCommit Required for every module on both platforms: 100% line and 100% branch coverage. A pass requires zero missed lines/branches and nonzero measured totals.
Coverage reports describe this run; missing or invalid reports never count as 100%. The required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Boot decoder sorted nested library names and archive normalization moved application-owned entries ahead of dependencies. This discarded declared classpath order and rejected valid packaged inputs containing different definitions of the same class.
Honor the integration’s ordered classpath and complete packaged
BOOT-INF/classpath.idxwhen selecting the first definition for the graph. Application ownership follows the selected bytes; an identical later application copy retains its ownership without changing precedence. Inputs without order evidence still require unambiguous definitions. There is no new startup, index, entrypoint or container requirement.Maven inputs preserve the model order within compile/runtime dependencies and place provided/system dependencies afterward as supplemental static type evidence. Both graph dependencies and source mappings honor Maven’s native
artifactHandler.isAddedToClasspathflag as well as scope. Non-classpath artifacts such as native tarballs are excluded according to Maven’s model; custom classpath artifact types remain supported. Source mappings retain the original compiler classpath order.Keep all original class bytes, annotations, resources and order in the production inventory. Changes to shadowed production definitions remain proof obligations: paired engine goldens accept an unchanged shadowed input with a controlled application change, and reject added shadowed body, annotation or resource changes. Cache keys distinguish the selection policy.
Depends on #9. This PR is stacked on
fix/signed-mr-projection.Validation:
MavenProjectInput.kthave 100% line and branch coverage against their current compiled class identities.All 13 checks in the full Build workflow pass on this commit. Both platforms pass all test shards, exact 100% line and branch coverage gates for every module, publication checks, and native Maven library, Boot JAR and WAR lifecycle verification. Petclinic input preparation passed, but its full analysis encountered a separate SootUp bytecode-conversion limitation. The separate Issue #5 performance evaluation was completed using real Netty multi-graph inputs; it did not establish sufficient benefit to adopt the proposed cache.