Skip to content

Fix: normalize movement vector for 1.21.5+ (fixes #831) #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EIHEI2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: normalize movement vector for 1.21.5+ (fixes #831) #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/dev/isxander/controlify/ingame/ControllerPlayerMovement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,20 @@ private void setMoveVec(float forward, float left) {
so this won't actually make any difference for most people.
But custom joystick configurations may produce irregular results, hence this is necessary.
*/
//? if >=1.21.5 {
/*
// Starting snapshot 25w02a, move vector is now normalised.
// This slows down the player when moving diagonally, this will be reflected
// by Controlify. This means that 25w02a and later targets will have differing movement mechanics
// in Controlify.
this.moveVector = new Vec2(left, forward).normalized();
*///?} else {
this.moveVector = new Vec2(left, forward);
float length = this.moveVector.length();
if (length > 1) {
this.moveVector = this.moveVector.scale(1f / length);
}
//?}
}

public static void updatePlayerInput(@Nullable LocalPlayer player) {
Expand Down