Fix: normalize movement vector for 1.21.5+ (fixes #831)#835
Open
EIHEI2 wants to merge 1 commit intoisXander:mainfrom
Open
Fix: normalize movement vector for 1.21.5+ (fixes #831)#835EIHEI2 wants to merge 1 commit intoisXander:mainfrom
EIHEI2 wants to merge 1 commit intoisXander:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the jittery movement issue reported in #831 for Minecraft 1.21.11.
Problem
Starting from Minecraft snapshot 25w02a (1.21.5+), the vanilla movement vector is normalized. However, Controlify was only limiting the vector length to 1 without normalizing it, causing inconsistent movement behavior, especially noticeable on multiplayer servers.
Solution
Added preprocessor directive to normalize the movement vector for versions >= 1.21.5, matching vanilla behavior. This ensures smooth, consistent movement across all directions.
Changes
Testing