Skip to content

fix: use cached disk mode for macOS guests to prevent APFS corruption #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarvinDontPanic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use cached disk mode for macOS guests to prevent APFS corruption #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion VirtualCore/Source/Virtualization/Helpers/VirtualMachineConfigurationHelper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ func createVZDiskImageStorageDeviceAttachment(url: URL, readOnly: Bool, guestTyp
// fixes this IO errors and disk corruption issues for Linux guest.
return try VZDiskImageStorageDeviceAttachment(url: url, readOnly: readOnly, cachingMode: .cached, synchronizationMode: .fsync)
} else {
return try VZDiskImageStorageDeviceAttachment(url: url, readOnly: readOnly)
// macOS guests also need cached mode to prevent APFS corruption under heavy I/O.
// See: UTM #4840, Lima VM #1957
return try VZDiskImageStorageDeviceAttachment(url: url, readOnly: readOnly, cachingMode: .cached, synchronizationMode: .fsync)
}
}

Expand Down