fix: use cached disk mode for macOS guests to prevent APFS corruption#664
Open
MarvinDontPanic wants to merge 1 commit intoinsidegui:mainfrom
Open
fix: use cached disk mode for macOS guests to prevent APFS corruption#664MarvinDontPanic wants to merge 1 commit intoinsidegui:mainfrom
MarvinDontPanic wants to merge 1 commit intoinsidegui:mainfrom
Conversation
The else branch for macOS guests was using the default cachingMode (.automatic), which causes APFS space manager corruption under heavy I/O. Apply the same .cached + .fsync fix that PR insidegui#332 applied to Linux guests. Fixes filesystem corruption where write() returns EILSEQ (errno 92) after sustained I/O workloads in macOS guest VMs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
.cached+.fsyncdisk caching mode to macOS guests, matching the fix already applied to Linux guests in PR #332.Problem
macOS guest VMs experience APFS filesystem corruption under heavy I/O because
VZDiskImageStorageDeviceAttachmentuses the defaultcachingMode: .automatic(effectively uncached). After sustained I/O (compilation, large git operations, concurrent writes), the APFS space manager becomes corrupted:This causes every subsequent
write()syscall to fail withEILSEQ(errno 92), making the VM completely unable to write files.fsck_apfs -ycannot repair the damage.Fix
Changed the
elsebranch increateVZDiskImageStorageDeviceAttachmentto usecachingMode: .cached, synchronizationMode: .fsyncfor macOS guests, identical to the Linux guest fix.Related