ci: pin openai/codex-action back to v1.11 (v1.12 hangs after turn completes) - #797
Merged
Conversation
…pletes) Reverts the v1.12 bump from #791. Since v1.12, heavy review runs on Linux never return after the codex turn completes: the action passes the runner's stdout/stderr descriptors to the whole codex process tree, and a surviving descendant keeps them open, so the step idles until timeout-minutes kills the job with the verdict already written (openai/codex-action#150). The CLI-side mitigation (codex 0.150.x) did not resolve it for this repo's drop-sudo runs; the action-side fix (openai/codex-action#151) is unmerged. Both attempts of the PR #796 review died this way (attempt 1 killed at the 60-minute timeout, attempt 2 stuck identically after the analysis finished). Also adds a dependabot ignore for openai/codex-action 1.12 so the broken version is not re-proposed; drop the ignore once the fixed release ships.
Overall assessment✅ Looks good — no unmitigated P0 or P1 findings. Executive summary
MethodologyNo findings. Estimators, assumptions, weighting, variance, inference, and defaults are unchanged. Code QualityNo findings. PerformanceNo findings. The rollback is intended to restore reliable CI completion. MaintainabilityNo findings. Cleanup conditions are documented alongside both changes. Tech DebtNo findings. The temporary version restriction is explicit and narrowly scoped. SecurityNo findings. Secret handling and sandbox configuration are unchanged; the action remains SHA-pinned. Documentation/TestsNo findings. The configuration files parse as valid YAML, and the inline rationale adequately documents this CI-only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai/codex-actionback to v1.11 (52fe01ec), reverting the v1.12 bump from chore(deps): bump openai/codex-action from 1.11 to 1.12 in the actions-minor-patch group #791. Since v1.12, heavy review runs on Linux hang after the codex turn completes: the action hands the runner's stdout/stderr descriptors to the whole codex process tree, and a surviving descendant keeps them open, so the step idles untiltimeout-minuteskills the job with the verdict already written (v1.12: Linux run never returns after the turn completes; job dies on timeout with the output file already written openai/codex-action#150). Both attempts of the PR feat(dml): DMLDiD survey-design and cluster support on both lanes (DML survey PR) #796 review died this way. The CLI-side mitigation (codex 0.150.x) was already live for those runs and did not help; the action-side fix (Fix action hang when descendants keep stdio open openai/codex-action#151) is still unmerged.ignoreforopenai/codex-actionversion 1.12 so the broken version is not re-proposed. Drop the ignore once the fixed release (v1.13+) ships and re-bump then.Methodology references (required if estimator / math changes)
Validation
Security / privacy