Skip to content

ci: fix codex-action pin comment format to satisfy workflow contract test - #798

Merged
igerber merged 1 commit into
mainfrom
fix/codex-action-pin-comment-format
Aug 28, 2026
Merged

ci: fix codex-action pin comment format to satisfy workflow contract test#798
igerber merged 1 commit into
mainfrom
fix/codex-action-pin-comment-format

Conversation

@igerber

@igerber igerber commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix the # v1.11 pin comment format introduced in ci: pin openai/codex-action back to v1.11 (v1.12 hangs after turn completes) #797: TestWorkflowCodexActionContract::test_run_codex_uses_pinned_action anchors the version comment to end-of-line (openai/codex-action@<sha> # v1[.N]$), and the trailing rationale prose on the uses: line broke it on main (Rust Backend Tests, pure Python leg: 1 failed, 13053 passed). The rationale now lives on its own comment lines above the pin; the uses: line ends with # v1.11.
  • No functional change: the pin stays at v1.11 (52fe01ec).

Methodology references (required if estimator / math changes)

  • Method name(s): N/A - no methodology changes
  • Paper / source link(s): N/A
  • Any intentional deviations from the source (and why): None

Validation

  • Tests added/updated: No test changes; tests/test_openai_review.py now passes locally (264 passed), including the previously failing contract test.
  • Backtest / simulation / notebook evidence (if applicable): N/A

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

…test

The v1.11 revert (#797) put the rationale on the `uses:` line itself, but
TestWorkflowCodexActionContract::test_run_codex_uses_pinned_action anchors
the version comment to end-of-line (`# v1[.N]$`), so the trailing prose
failed the Rust Backend Tests suite on main. Move the rationale to its own
comment lines above the pin; the `uses:` line now ends with `# v1.11`.

The pin itself (52fe01ec, v1.11) is unchanged.
@github-actions

Copy link
Copy Markdown

Overall Assessment: ✅ Looks good

Executive Summary

  • The change is limited to a GitHub Actions comment format.
  • The action remains pinned to the same immutable SHA and version.
  • No methodology, estimator, inference, runtime, or security behavior changes.
  • The revised uses: line satisfies the described end-of-line contract.

Methodology

No findings. The Methodology Registry is not implicated because no statistical code or defaults changed.

Code Quality

No findings. Moving the rationale above the uses: line preserves clarity and valid YAML structure.

Performance

No findings. No runtime behavior changed.

Maintainability

No findings. The pin rationale remains adjacent to the dependency.

Tech Debt

No findings. The existing re-bump condition remains documented.

Security

No findings. The action remains pinned to the same full commit SHA.

Documentation/Tests

No findings. The modification directly restores compatibility with the existing workflow contract test; additional tests are unnecessary for this comment-only change.

@igerber igerber added the ready-for-ci Triggers CI test workflows label Aug 28, 2026
@igerber
igerber merged commit 1d61d46 into main Aug 28, 2026
29 of 30 checks passed
@igerber
igerber deleted the fix/codex-action-pin-comment-format branch August 28, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-ci Triggers CI test workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant