ci: fix codex-action pin comment format to satisfy workflow contract test - #798
Merged
Conversation
…test The v1.11 revert (#797) put the rationale on the `uses:` line itself, but TestWorkflowCodexActionContract::test_run_codex_uses_pinned_action anchors the version comment to end-of-line (`# v1[.N]$`), so the trailing prose failed the Rust Backend Tests suite on main. Move the rationale to its own comment lines above the pin; the `uses:` line now ends with `# v1.11`. The pin itself (52fe01ec, v1.11) is unchanged.
Overall Assessment: ✅ Looks goodExecutive Summary
MethodologyNo findings. The Methodology Registry is not implicated because no statistical code or defaults changed. Code QualityNo findings. Moving the rationale above the PerformanceNo findings. No runtime behavior changed. MaintainabilityNo findings. The pin rationale remains adjacent to the dependency. Tech DebtNo findings. The existing re-bump condition remains documented. SecurityNo findings. The action remains pinned to the same full commit SHA. Documentation/TestsNo findings. The modification directly restores compatibility with the existing workflow contract test; additional tests are unnecessary for this comment-only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# v1.11pin comment format introduced in ci: pin openai/codex-action back to v1.11 (v1.12 hangs after turn completes) #797:TestWorkflowCodexActionContract::test_run_codex_uses_pinned_actionanchors the version comment to end-of-line (openai/codex-action@<sha> # v1[.N]$), and the trailing rationale prose on theuses:line broke it on main (Rust Backend Tests, pure Python leg: 1 failed, 13053 passed). The rationale now lives on its own comment lines above the pin; theuses:line ends with# v1.11.52fe01ec).Methodology references (required if estimator / math changes)
Validation
tests/test_openai_review.pynow passes locally (264 passed), including the previously failing contract test.Security / privacy