Skip to content

Fix ftfy import for PRX Pipeline #13154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dg845 wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −12
Open

Fix ftfy import for PRX Pipeline #13154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c119560
Guard ftfy import with is_ftfy_available
dg845 Feb 17, 2026
010104b
Remove xfail for PRX pipeline tests as they appear to work on transfo…
dg845 Feb 17, 2026
ae66644
make style and make quality
dg845 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/diffusers/pipelines/prx/pipeline_prx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import urllib.parse as ul
from typing import Callable

import ftfy
import torch
from transformers import (
AutoTokenizer,
Expand All @@ -34,13 +33,13 @@
from diffusers.pipelines.pipeline_utils import DiffusionPipeline
from diffusers.pipelines.prx.pipeline_output import PRXPipelineOutput
from diffusers.schedulers import FlowMatchEulerDiscreteScheduler
from diffusers.utils import (
logging,
replace_example_docstring,
)
from diffusers.utils import is_ftfy_available, logging, replace_example_docstring
from diffusers.utils.torch_utils import randn_tensor


if is_ftfy_available():
Copy link
Member

@sayakpaul sayakpaul Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could we check it across the codebase (core) and tackle in this PR?

Copy link
Collaborator Author

@dg845 dg845 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is currently the only place in the core codebase (so excluding community pipelines) where import ftfy is unguarded.

import ftfy

DEFAULT_RESOLUTION = 512

ASPECT_RATIO_256_BIN = {
Expand Down
7 changes: 0 additions & 7 deletions tests/pipelines/prx/test_pipeline_prx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import unittest

import numpy as np
import pytest
import torch
from transformers import AutoTokenizer
from transformers.models.t5gemma.configuration_t5gemma import T5GemmaConfig, T5GemmaModuleConfig
Expand All @@ -11,17 +10,11 @@
from diffusers.models.transformers.transformer_prx import PRXTransformer2DModel
from diffusers.pipelines.prx.pipeline_prx import PRXPipeline
from diffusers.schedulers import FlowMatchEulerDiscreteScheduler
from diffusers.utils import is_transformers_version

from ..pipeline_params import TEXT_TO_IMAGE_PARAMS
from ..test_pipelines_common import PipelineTesterMixin


@pytest.mark.xfail(
condition=is_transformers_version(">", "4.57.1"),
reason="See https://github.com/huggingface/diffusers/pull/12456#issuecomment-3424228544",
strict=False,
)
class PRXPipelineFastTests(PipelineTesterMixin, unittest.TestCase):
pipeline_class = PRXPipeline
params = TEXT_TO_IMAGE_PARAMS - {"cross_attention_kwargs"}
Expand Down
Loading