Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Feb 17, 2026
| from diffusers.utils.torch_utils import randn_tensor | ||
|
|
||
|
|
||
| if is_ftfy_available(): |
Member
There was a problem hiding this comment.
Thanks! Could we check it across the codebase (core) and tackle in this PR?
Collaborator
Author
There was a problem hiding this comment.
I believe this is currently the only place in the core codebase (so excluding community pipelines) where import ftfy is unguarded.
Member
|
The failing tests seem to be quite related 👀 Cc: @DN6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the
ftfyimport for the PRX pipeline by guarding the import withis_ftfy_available.It also removes the
xfailmark for the PRX pipeline tests as the tests appear to work now fortransformers>4.57.1.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul
@DN6