Skip to content

[Snyk] Fix for 3 vulnerabilities #11564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/backend-app-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/backend-tasks": "workspace:^",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +35 to +43
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency updates from Snyk seem incorrect and will likely break the build. Most of these changes are downgrading packages to very old versions instead of updating them. For example, @backstage/backend-plugin-api is being downgraded from a workspace version (currently 0.5.5-next.0) to 0.1.0.

This approach breaks the workspace: protocol used in this monorepo. The correct way to fix these vulnerabilities is to update the package versions within the workspace itself, not to pin them to arbitrary, outdated versions.

Additionally, the PR description warns that yarn.lock was not updated. This is a critical omission that would prevent these changes from being applied correctly and could cause inconsistencies.

Due to these issues, I recommend rejecting this automated pull request and addressing the vulnerabilities manually by properly updating the workspace packages.

"@backstage/types": "workspace:^",
"@manypkg/get-packages": "^1.1.3",
"@types/cors": "^2.8.6",
Expand Down
Loading