-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 3 vulnerabilities #11564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving three identified vulnerabilities within its Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix three security vulnerabilities by updating dependencies. However, the proposed changes are problematic. They replace workspace: dependencies with pinned, and in most cases, significantly older versions of packages. This will likely break the build and is not the correct way to manage dependencies in this monorepo. Furthermore, the yarn.lock file has not been updated as noted in the PR description. I've left a critical comment on the package.json file explaining the issue. The PR should be rejected in its current state, and the vulnerabilities should be addressed by correctly updating dependencies within the workspace.
| "@backstage/backend-common": "0.24.1", | ||
| "@backstage/backend-plugin-api": "0.1.0", | ||
| "@backstage/backend-tasks": "workspace:^", | ||
| "@backstage/cli-common": "workspace:^", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/config-loader": "workspace:^", | ||
| "@backstage/config-loader": "0.1.1", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-auth-node": "workspace:^", | ||
| "@backstage/plugin-permission-node": "workspace:^", | ||
| "@backstage/plugin-auth-node": "0.1.0", | ||
| "@backstage/plugin-permission-node": "0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependency updates from Snyk seem incorrect and will likely break the build. Most of these changes are downgrading packages to very old versions instead of updating them. For example, @backstage/backend-plugin-api is being downgraded from a workspace version (currently 0.5.5-next.0) to 0.1.0.
This approach breaks the workspace: protocol used in this monorepo. The correct way to fix these vulnerabilities is to update the package versions within the workspace itself, not to pin them to arbitrary, outdated versions.
Additionally, the PR description warns that yarn.lock was not updated. This is a critical omission that would prevent these changes from being applied correctly and could cause inconsistencies.
Due to these issues, I recommend rejecting this automated pull request and addressing the vulnerabilities manually by properly updating the workspace packages.
WalkthroughThis pull request updates the dependency management strategy for the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PKG as package.json
participant WS as Workspace Dependencies
participant NPM as NPM Registry
Note over Dev,NPM: Dependency Resolution Change
Dev->>PKG: Update dependency versions
alt Before Change (workspace:^)
PKG->>WS: Resolve @backstage/backend-common
WS-->>PKG: Return local workspace version
else After Change (0.24.1)
PKG->>NPM: Resolve @backstage/backend-common@0.24.1
NPM-->>PKG: Return published version 0.24.1
end
Note over PKG,NPM: Same pattern for:<br/>- backend-plugin-api (0.1.0)<br/>- config-loader (0.1.1)<br/>- plugin-auth-node (0.1.0)<br/>- plugin-permission-node (0.1.0)
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/backend-app-api/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR transitions the backend-app-api package from workspace protocol dependencies to pinned version numbers for five Backstage packages.
@backstage/backend-commonfromworkspace:^to0.24.1@backstage/backend-plugin-apifromworkspace:^to0.1.0@backstage/config-loaderfromworkspace:^to0.1.1@backstage/plugin-auth-nodefromworkspace:^to0.1.0@backstage/plugin-permission-nodefromworkspace:^to0.1.0