Skip to content

feat(studio): route GSAP tween add/update/delete through SDK (§3.5 PR1)#1469

Open
vanceingalls wants to merge 1 commit into
06-15-chore_studio_document_css-path_position_cut-over_gsap-path_intentionally_deferred_3.3_from
06-15-feat_studio_route_gsap_tween_add_update_delete_through_sdk_3.5_pr1_
Open

feat(studio): route GSAP tween add/update/delete through SDK (§3.5 PR1)#1469
vanceingalls wants to merge 1 commit into
06-15-chore_studio_document_css-path_position_cut-over_gsap-path_intentionally_deferred_3.3_from
06-15-feat_studio_route_gsap_tween_add_update_delete_through_sdk_3.5_pr1_

Conversation

@vanceingalls

Copy link
Copy Markdown
Collaborator

Summary

  • sdkGsapTweenPersist helper added to sdkCutover.ts — routes add/set/remove GSAP tween ops through the SDK's acorn/magic-string path, with server fallback on SDK miss/error
  • addGsapAnimation (from/to/fromTo only), updateGsapMeta, deleteGsapAnimation in useGsapAnimationOps now try SDK first
  • updateGsapProperty, addGsapProperty, updateGsapFromProperty, addGsapFromProperty in useGsapPropertyDebounce now try SDK first
  • removeGsapProperty / removeGsapFromProperty stay server-authoritative: null ≠ removal in upsertProp; deleteAllForSelector stays server-authoritative: no SDK op
  • addGsapAnimation with method = "set" stays server-authoritative: GsapTweenSpec has no set method
  • 5 new unit tests for sdkGsapTweenPersist

Open decisions

  • removeGsapProperty/removeGsapFromProperty: upsertProp in the acorn writer treats null as a literal null value, not removal. To support removal via SDK, a removeGsapProperty SDK op would be needed (separate PR or accepted as server-authoritative for now).
  • deleteAllForSelector: no SDK op exists. Stays server-authoritative.
  • addGsapAnimation with method = "set": GsapTweenSpec doesn't have a set method; stays server-authoritative.

Test plan

  • Build passes (bun run build)
  • Tests pass (bun run test) — 37 sdkCutover tests
  • Lint/format clean
  • 600-line Studio gate passes
  • Manual: open Studio on a GSAP comp, add/edit/delete a tween, confirm sdk_cutover_success telemetry fires and undo works

🤖 Generated with Claude Code

Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant