feat(studio): s7.5 — make sdk cutover always-on, delete shadow scaffolding#1462
Open
vanceingalls wants to merge 1 commit into
Conversation
…lding SDK cutover is now unconditionally enabled. Removes STUDIO_SDK_SHADOW_ENABLED and STUDIO_SDK_CUTOVER_ENABLED feature flags, deletes sdkShadow.ts and its tests, moves patchOpsToSdkEditOps into sdkCutover.ts, and removes the onDomEditPersisted shadow callback from useDomEditSession. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vanceingalls
changed the base branch from
sdk-stage7-studio-s7step4
to
graphite-base/1462
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes the shadow scaffolding introduced for dual-write telemetry and makes SDK cutover unconditionally active for all supported op types.
Why
Shadow mode (
sdkShadow.ts) was a stepping stone: it dispatched SDK ops in parallel with the legacy server-patch path to measure parity. That telemetry work is done. The two feature flags (STUDIO_SDK_SHADOW_ENABLED,STUDIO_SDK_CUTOVER_ENABLED) were held as kill-switches during roll-out. With cutover proven stable in production (supported ops: setStyle, setAttribute, setHtmlAttribute, setText), the flags are unnecessary overhead.How
sdkShadow.tsandsdkShadow.test.tspatchOpsToSdkEditOpsfromsdkShadow.tsintosdkCutover.tsas an unexported internal (only used bysdkCutoverPersist)manualEditingAvailability.tsshouldUseSdkCutoversignature simplified:(hasSession, hfId, ops)— removedflagEnabledbooleansdkSessionfromuseDomEditSessionparams (was only passed through to the now-deleted shadow dispatch callback)sdkCutoverPersist,App.tsx,sdkCutover.test.tsTest plan
sdkCutover.test.ts: 20 tests — all shouldUseSdkCutover paths, patchOpsToSdkEditOps translation, full persist flowsdkShadow.test.ts) deleted with the module