Repository navigation
feat(tui): end a terminal from its panel with Alt+X - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53.
A running terminal's footer now offers
Alt+X end it, next toCtrl+Q leave it running. The key, or a click on its hint, asksEnd the session? It stops whatever runs in itwithy yes · n no; while it asks, keys don't reach the shell.On yes, berth sends the session a hangup through
sessions.signal, as closing a terminal window does, and a kill if it still runs 5 seconds later. Once it has ended, the panel closes; a session started from the panel is forgotten, as Enter would forget it. A process's output has no shell, so only terminals get the key.The two ways out of the panel now come first in the footer, so a narrow panel doesn't cut them off.
This is the behaviour #54 proposed, written against the current screens: the old terminal UI that PR also changed is gone.