Repository navigation
feat(tui): end a terminal from its panel with Alt+X - #54
Closed
ReaperMaga wants to merge 1 commit into
Closed
ReaperMaga wants to merge 1 commit into
ReaperMaga wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for this, and for the clear write-up. Since you opened it, the old terminal UI was removed and the screens moved into berth-page, so this no longer applies to main. I've carried your design over in #78: Alt+X asks first, sends a hangup and then a kill after 5 seconds, and the panel closes once the session has ended. It closes #53 when it is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53.
The footer of a running terminal never said how to end the session. Now it reads:
End the session "agent on studio"? This stops whatever runs in it.withy yes · n no. While it asks, keys don't reach the shell.HUPto the session throughsessions.signal, as closing a terminal window would. bash passes the hangup on to its jobs. If the session is still running 5 seconds later, berth sendsKILL.Ending the session…. Once it has ended, the panel closes by itself, and a session started from the panel is forgotten, as Enter would forget it.berth-tuipanel (draw_view/view_event/HostView), so berth-remote, the page ofberth serve --weband the berth terminal UI all get it. Both transports gainedRequest::Signal.docs/.../use/overview.mdxlists Alt+X.Checks
host::tests::a_terminal_is_ended_from_its_panel_after_a_yescovers the clickable hint, the question, no, yes →HUP, theKILLfallback and the panel closing.cargo clippy(workspace,--features web, wasm32),cargo fmt --checkand vale pass.cargo test --lockedpasses exceptprovision::tests::the_look_at_the_first_boot_carries_no_password_and_a_checked_cursor, which fails the same way onmainon this machine because it reads the machine's own first-boot state.🤖 Generated with Claude Code