Skip to content

test: order native socket setup and cancellation checks #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roodboi merged 2 commits into from
Oct 9, 2026
Merged

test: order native socket setup and cancellation checks #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b20cbe0
test(native): set up timeout and cancellation observations first
Oct 9, 2026
eeeb298
Merge remote-tracking branch 'origin/next' into fix/native-half-close…
Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/runtime-core/src/provider/host_endpoint/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,11 +306,11 @@ fn accepted_stream_preserves_payload_and_half_close() {
peer.write_all(b"reply").unwrap();
});
let mut stream = endpoint.connect(Duration::from_secs(2)).unwrap();
stream.write_all(b"synthetic endpoint payload").unwrap();
stream.shutdown(std::net::Shutdown::Write).unwrap();
stream
.set_read_timeout(Some(Duration::from_secs(2)))
.unwrap();
stream.write_all(b"synthetic endpoint payload").unwrap();
stream.shutdown(std::net::Shutdown::Write).unwrap();
let mut response = String::new();
stream.read_to_string(&mut response).unwrap();
assert_eq!(response, "reply");
Expand Down
3 changes: 2 additions & 1 deletion packages/runtime-core/src/provider/relay_owner/managed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2361,8 +2361,9 @@ mod tests {
.unwrap();
let canceled = Arc::clone(&retry.0.canceled);
drop(retry);
assert!(canceled.load(Ordering::Acquire));
// The reactor may still hold the command clone after delivering its reply.
fixture.owner.verify_alive().unwrap();
assert!(canceled.load(Ordering::Acquire));
assert!(authenticate(&fixture.sockets[0], &fresh.credential).is_err());
assert!(
fixture
Expand Down
Loading