Repository navigation
test: order native socket setup and cancellation checks - #232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Rust socket tests configured or checked state before establishing the ordering they rely on. Configure the existing two-second read timeout before sending the half-close payload, and check dropped relay-command cancellation after the existing reactor liveness barrier. All payload, FIN, credential-refusal assertions and time budgets remain unchanged; production behavior is unchanged.
Validation: independent review of the exact two-file diff against current
next; fresh default Rust suite (1,114 passed, 63 ignored, zero failures), both affected tests with all features, formatting, all-target default Clippy, and tracked-file privacy checks. Hosted CI remains required. The earlier hosted timeout-configurationEINVALis recorded; its kernel cause is unproven.Release intent: test-only ordering correction; no release or runtime behavior change.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.