Skip to content

fix: read studio.deploy workflow run instead of Request-parse HOLD - #1853

Merged
groupthinking merged 2 commits into
mainfrom
cursor/studio-deploy-workflow-run-d09a
Sep 12, 2026
Merged

fix: read studio.deploy workflow run instead of Request-parse HOLD#1853
groupthinking merged 2 commits into
mainfrom
cursor/studio-deploy-workflow-run-d09a

Conversation

@groupthinking

@groupthinking groupthinking commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Canonical issue

Residual after #1850. AXIOM re-dogfood XYMcBrFSJ4c on dpl_3o6VDNVej7vkA82TQKDNWhkxLGYs HOLDs with Failed to read workflow run (receipt er:gate:v1:wrun_01M2A9Z9SYXD59NG211W9N8EQA). Progress: Failed to read workflow return value is gone.

Outcome

Studio Attempt deploy can read the Workflow DevKit run. GET no longer HOLDs solely because undici fetch treated getRun()’s Request as a URL string. A real deploy can pass through a backend-supplied https live URL + EventRelay receipt. Missing evidence still HOLDs / REJECTs / ESCALATEs with a visible receipt chip. No “Deploy completed” overclaim.

Scope

Risk

  • Risk level: low
  • Failure mode: if the backend job is still transcribing when WDK step retries exhaust, Studio HOLDs with that real job reason (not the generic unread-run string)
  • Rollback: revert this PR; G.A.T.E. contract unchanged

Verification

  • Focused tests: 88 passed (world-vercel-fetch, GET [runId], studio-workflow, gate-transition, pipeline-async-job, studio-pipeline-status, pipeline-backend-health, POST studio-deploy, isolation); 39/39 re-verified after the tsc cast
  • Required CI on this head (fe434762a)
  • Review threads resolved

Production evidence

  • Prod logs on dpl_3o6VDNVej7vkA82TQKDNWhkxLGYs: GET /api/workflows/studio-deploy/wrun_01M2A9Z9SYXD59NG211W9N8EQA → 500 TypeError: Failed to parse URL from [object Request] / ERR_INVALID_URL input [object Request]
  • Preview dpl_HWDVNQVPgmJecxUjJcK4sW3z7N9g failed tsc on the first head; this head drops the Response cast.
  • After merge: expect prod READY dpl_… on v0-uvai. AXIOM re-dogfoods XYMcBrFSJ4c — must not HOLD for Failed to read workflow run or Failed to read workflow return value.

Agent handoff

  • One canonical cut (studio.deploy workflow-run Request parse)
  • No competing open PR for the same residual
  • Acceptance criteria satisfied on prod Attempt deploy
  • Required checks pass on the current head
  • Human decision requested only if EVENTRELAY_API_KEY is missing on the Vercel → api.uvai.io path (Hayden-only secret; not this cut)
Open in Web Open in Cursor 

undici fetch rejects getRun's Request argument; GET swallowed that as
Failed to read workflow run. Keep Request inputs on Next/Node fetch.

Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 12, 2026 8:13am UTC

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a42e086b-f091-4a94-ad3a-745eb4caf3c4


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests labels Sep 12, 2026
@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA fe43476.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Comment thread apps/web/src/lib/world-vercel-fetch.ts Outdated
Drop the undici Response→Response cast that failed Vercel tsc.

Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
@groupthinking
groupthinking merged commit f8ca08c into main Sep 12, 2026
27 checks passed
@groupthinking
groupthinking deleted the cursor/studio-deploy-workflow-run-d09a branch September 12, 2026 08:14
@linear-code

linear-code Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

GRV-528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants