fix: skip process handoff when deploy transcript is ready - #1880
Merged
Conversation
Origin answers within a 12s sync budget. Slow deploys persist a pollable job_id so Studio never waits for Cloudflare HTTP 524. Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Restore #1859 reuse so HTTP 524 no longer starts URL-only /videos/process. Origin 202 remains the async path past 524. Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
groupthinking
marked this pull request as ready for review
September 12, 2026 09:38
Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Drop the duplicate PIPELINE_RESPONSE_BUFFER_MS import and run dashboard store persistence under Vitest so the required check can go green for the reuse-after-524 cut. Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Contributor
3 tasks
10 tasks
Contributor
🔍 PR Validation |
Contributor
🔴 E2E Test Results: FAILURE DETECTED
Test Output |
kk-agent
pushed a commit
that referenced
this pull request
Sep 12, 2026
* fix: retry studio.deploy on timeout abort instead of HOLD AbortSignal.timeout was failing the WDK kickoff/poll and client status reads with the raw DOM message, so G.A.T.E. HOLDs after #1880 cleared bot/524. Retry origin 202, keep polling, never re-hit process. Co-authored-by: Hayden <groupthinking@users.noreply.github.com> * docs: record timeout-abort PR verification evidence Local Vitest 703 and lint 0 errors; GitHub core CI still queued. Co-authored-by: Hayden <groupthinking@users.noreply.github.com> * fix: poll studio.deploy with durable sleep, not step abort Split the WDK job wait onto sleep('10s') between short status reads so Vercel cannot abort-timeout a 180s in-step setTimeout after kickoff. Co-authored-by: Hayden <groupthinking@users.noreply.github.com> * fix: lazy-load GeminiVideoMasterAgent on agents import Importing agents.action_implementer no longer eager-loads the video master agent, which failed the core pytest job under full CI deps. Co-authored-by: Hayden <groupthinking@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Continues the studio.deploy finish line after #1875 (HTTP 524 cleared, YouTube bot wall returned).
Outcome
Restore #1859 ready-transcript reuse so Attempt deploy does not re-hit YouTube via
/videos/processwhen the pack/transcript is already ready, while keeping #1875 async past HTTP 524 via origin202+job_id. Claim guard stays: no live success without a verifiedhttps://hostname URL + EventRelay receipt.AXIOM:
dpl_BK1hFnDuN366N5WBAUpAsLka9iwP/XYMcBrFSJ4c, receipter:gate:v1:wrun_01M2AF8WD3G4VCB63KEBX311HV. HTTP 524 cleared. Regression:Sign in to confirm you’re not a bot. No live URL.Scope
/videos/processwhenever a usable Studio transcript exists (524 / abort timeout / 401 / bot miss)/video-to-software202+job_idis the async handoff past 524 (not process)/videos/process(fix: async-handoff studio.deploy kickoff past HTTP 524 #1875)test-frontend: drop duplicatePIPELINE_RESPONSE_BUFFER_MSimport; run dashboard persistence under Vitest--cookies/ auth inventRisk
Verification
Tied to head
78373b66e.validate/guards/lint-*/build/test/test-frontend) on this headPrior head
48cc6639c:test-frontendfailed two suites this cut did not author (pipeline-route.test.tsduplicate import;dashboard-store.persistence.test.tsnode:test collected by Vitest). Other core checks passed. Not merged.Production evidence
Pending merge-when-core-green → prod READY
dpl_. Cannot signed-in dogfood AXIOM in this environment. Honest HOLD ≠ bot and ≠ 524 is allowed; no invented live URL.Agent handoff