fix: parse studio.deploy workflow return instead of generic HOLD - #1850
Merged
Conversation
Backend jobs finish as complete; GET was swallowing returnValue. Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🔍 PR Validation |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
groupthinking
marked this pull request as ready for review
September 12, 2026 07:48
Contributor
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Residual after #1848 (Must 1–4 PASS). AXIOM re-dogfood XYMcBrFSJ4c HOLDs with
Failed to read workflow return value(receipter:gate:v1:wrun_01M2A8RXT1HS8NPW70HV6AA0YV). Not anEVENTRELAY_API_KEY/ auth cut.Outcome
Studio Attempt deploy no longer HOLDs solely because GET
/api/workflows/studio-deploy/:runIdcould not read a Workflow DevKit return value. A real deploy attempt can pass through a backend-supplied https live URL + EventRelay receipt. Missing evidence still HOLDs / REJECTs / ESCALATEs with a visible receipt chip. No “Deploy completed” overclaim.Scope
JobStatus.complete("complete") as terminal — source of truth insrc/youtube_extension/backend/api/v1/models.pyreturnValuecause instead of swallowing it asFailed to read workflow return valuegetRun/returnValueinwithWorldVercelFetch(same undici world asstart())live_urland backendjob.error(never invent a URL)/api/v1/video-to-softwarefor a real live URL; 401/403 falls through to/videos/process(not an auth cut)completedbut the return value is not readable yetEVENTRELAY_API_KEYon VercelRisk
Verification
pipeline-async-job,studio-workflow,studio-deploy,gate-transition,studio-pipeline-status,pipeline-backend-health, isolation, studio-deploy POST + GET[runId])Production evidence
2ebf19b527f62ae10cf8e4b12bbabd6704150a8c(fix: parse studio.deploy workflow return instead of generic HOLD #1850 squash)dpl_3o6VDNVej7vkA82TQKDNWhkxLGYson v0-uvai (uvai.ioalias)https://api.uvai.io/api/v1/health→ HTTP 200https://uvai.io/→ HTTP 200Failed to read workflow return value. PASS + clickable live URL, or honest HOLD/REJECT with a different real reason.Agent handoff
EVENTRELAY_API_KEYis missing on the Vercel → api.uvai.io path (Hayden-only secret; not this cut)