Skip to content

fix: parse studio.deploy workflow return instead of generic HOLD - #1850

Merged
kk-agent merged 1 commit into
mainfrom
cursor/studio-deploy-workflow-return-d09a
Sep 12, 2026
Merged

fix: parse studio.deploy workflow return instead of generic HOLD#1850
kk-agent merged 1 commit into
mainfrom
cursor/studio-deploy-workflow-return-d09a

Conversation

@groupthinking

@groupthinking groupthinking commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Canonical issue

Residual after #1848 (Must 1–4 PASS). AXIOM re-dogfood XYMcBrFSJ4c HOLDs with Failed to read workflow return value (receipt er:gate:v1:wrun_01M2A8RXT1HS8NPW70HV6AA0YV). Not an EVENTRELAY_API_KEY / auth cut.

Outcome

Studio Attempt deploy no longer HOLDs solely because GET /api/workflows/studio-deploy/:runId could not read a Workflow DevKit return value. A real deploy attempt can pass through a backend-supplied https live URL + EventRelay receipt. Missing evidence still HOLDs / REJECTs / ESCALATEs with a visible receipt chip. No “Deploy completed” overclaim.

Scope

  • Included:
    • Treat backend JobStatus.complete ("complete") as terminal — source of truth in src/youtube_extension/backend/api/v1/models.py
    • Surface the failed-run returnValue cause instead of swallowing it as Failed to read workflow return value
    • Wrap GET getRun / returnValue in withWorldVercelFetch (same undici world as start())
    • Pass through nested live_url and backend job.error (never invent a URL)
    • Try FastAPI /api/v1/video-to-software for a real live URL; 401/403 falls through to /videos/process (not an auth cut)
    • Keep polling when status is completed but the return value is not readable yet
  • Explicitly excluded:
    • Inventing a live URL
    • Weakening G.A.T.E. claim guard
    • Setting EVENTRELAY_API_KEY on Vercel

Risk

  • Risk level: low
  • Failure mode: if video-to-software returns no verified https live URL, Studio HOLDs with the real job/workflow reason (not the generic unread-return string)
  • Rollback: revert this PR; G.A.T.E. contract unchanged

Verification

  • Focused tests: 85 passed (pipeline-async-job, studio-workflow, studio-deploy, gate-transition, studio-pipeline-status, pipeline-backend-health, isolation, studio-deploy POST + GET [runId])
  • Required CI on this head (core green; Coverage uploaded; Trivy flake neutral)
  • Review threads: none

Production evidence

  • Merged: 2ebf19b527f62ae10cf8e4b12bbabd6704150a8c (fix: parse studio.deploy workflow return instead of generic HOLD #1850 squash)
  • Prod READY: dpl_3o6VDNVej7vkA82TQKDNWhkxLGYs on v0-uvai (uvai.io alias)
  • Live probe: https://api.uvai.io/api/v1/health → HTTP 200
  • Live probe: https://uvai.io/ → HTTP 200
  • AXIOM accept: re-dogfood XYMcBrFSJ4c — must not HOLD solely for Failed to read workflow return value. PASS + clickable live URL, or honest HOLD/REJECT with a different real reason.

Agent handoff

  • One canonical cut (studio.deploy workflow-return / live URL parse)
  • No competing open PR for the same residual
  • Acceptance criteria satisfied on prod Attempt deploy (AXIOM re-dogfood)
  • Required checks pass on the current head
  • Human decision requested only if EVENTRELAY_API_KEY is missing on the Vercel → api.uvai.io path (Hayden-only secret; not this cut)
Open in Web Open in Cursor 

Backend jobs finish as complete; GET was swallowing returnValue.

Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 12, 2026 7:48am UTC

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 82f0e387-ed45-4119-b3c6-8820ec2d3cce


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ Large PR detected (512 lines changed)

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 722fd85.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions github-actions Bot added documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests labels Sep 12, 2026
@groupthinking
groupthinking marked this pull request as ready for review September 12, 2026 07:48
@kk-agent
kk-agent merged commit 2ebf19b into main Sep 12, 2026
52 checks passed
@kk-agent
kk-agent deleted the cursor/studio-deploy-workflow-return-d09a branch September 12, 2026 07:54
@linear-code

linear-code Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

GRV-526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants