Skip to content

test(pool): fix flaky TestRunGCReapsThenStops #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ernado merged 1 commit into from
Nov 10, 2026
Merged

test(pool): fix flaky TestRunGCReapsThenStops #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions pool/pool_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ func TestRunGCReapsThenStops(t *testing.T) {

go func() { p.RunGC(ctx); close(done) }()

// Wait for the idle bot to be reaped.
// Wait for the idle bot to be reaped and killed. reap removes the bot from
// the map under the lock and kills it after unlocking, so both must be
// awaited.
deadline := time.After(2 * time.Second)

for {
Expand All @@ -153,21 +155,17 @@ func TestRunGCReapsThenStops(t *testing.T) {
n := len(p.bots)
p.mu.Unlock()

if n == 0 {
if n == 0 && killed.Load() {
break
}

select {
case <-deadline:
t.Fatal("idle bot was not reaped")
t.Fatalf("idle bot was not reaped (bots=%d, killed=%v)", n, killed.Load())
case <-time.After(5 * time.Millisecond):
}
}

if !killed.Load() {
t.Fatal("reaped bot should be killed")
}

cancel()

select {
Expand Down
Loading