Skip to content

test(pool): fix flaky TestRunGCReapsThenStops - #481

Merged
ernado merged 1 commit into
mainfrom
test/pool-gc-flake
Nov 10, 2026
Merged

ernado merged 1 commit into
mainfrom
test/pool-gc-flake

Conversation

@ernado

@ernado ernado commented Nov 10, 2026

Copy link
Copy Markdown
Member

reap removes the bot from the map under the lock and calls kill after unlocking, so the test could see an empty map before the kill happened (failed on ubuntu in #480). Wait for both conditions.

reap deletes the bot from the map under the lock and kills it after
unlocking, so the test could observe an empty map before kill ran.
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.52%. Comparing base (0edbcba) to head (281d739).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files         119      119           
  Lines        8578     8578           
=======================================
  Hits         6736     6736           
  Misses       1305     1305           
  Partials      537      537           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ernado
ernado merged commit 7dbbb83 into main Nov 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant