Repository navigation
test(pool): fix flaky TestRunGCReapsThenStops - #481
Merged
Merged
Conversation
reap deletes the bot from the map under the lock and kills it after unlocking, so the test could observe an empty map before kill ran.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 119 119
Lines 8578 8578
=======================================
Hits 6736 6736
Misses 1305 1305
Partials 537 537 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reapremoves the bot from the map under the lock and callskillafter unlocking, so the test could see an empty map before the kill happened (failed on ubuntu in #480). Wait for both conditions.