Repository navigation
ci: read the Update Skill Gemini model from GEMINI_MODEL - #1057
Merged
Merged
Conversation
update_skill.py hardcoded gemini-2.5-flash, which the API no longer serves, so the workflow has failed with a 404 on every release since September. It now reads the GEMINI_MODEL repository variable, as the issue triage workflow already does.
Coverage (unit tests)Compared against
Line and branch coverage from unit test reports. History is recorded on the |
Contributor
Coverage (instrumentation tests)
|
dkhawk
approved these changes
Oct 29, 2026
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Update Skillworkflow has failed on every release since September (latest run: https://github.com/googlemaps/android-maps-compose/actions/runs/37822226850) with:update_skill.pyhardcodedgemini-2.5-flash. It now reads theGEMINI_MODELrepository variable (currentlygemini-3.8-flash), which the issue triage workflow already uses successfully, and falls back to the same default as the other scripts.This is only the model fix. #991 also hardens the workflow against prompt injection; that part can still go in on top, with a one-line conflict in
update_skill.py.Can be verified after merge with a manual
workflow_dispatchrun ofUpdate Skill.