-
Notifications
You must be signed in to change notification settings - Fork 698
Shivaneep o11y tracer helper #9070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
87f6027
feat(generator): add enable_telemetry_tracing option and client inter…
shivanee-p 6e156ef
feat(gax): accept clientOptions in createApiCall for telemetry tracing
shivanee-p 6bc7474
feat(gax): check internalTelemetryInfo for tracingEnabled in createAp…
shivanee-p 5ecd8a9
feat(generator): import getGaxTracer when enableTelemetryTracing is set
shivanee-p c1f66f0
feat(generator): add internalTelemetryInfo configuration when enableT…
shivanee-p 9a210e5
refactor(gax): extract invokeCall and return conditionally based on t…
shivanee-p 28ae7fc
fix(gax): gate OpenTelemetry tracing behind clientOptions and env var
shivanee-p aa96ceb
feat(gax): add TracerHelper for observability trace contexts
shivanee-p 2bd856a
update TracerHelper.ts with user changes
shivanee-p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { context, trace, Tracer } from `@opentelemetry/api`; | ||
| import * as grpc from '@grpc/grpc-js'; | ||
|
|
||
| export interface StaticTraceContext { | ||
| gcpClientService?: string; | ||
| gcpVersion?: string; | ||
| gcpRepo?: string; | ||
| gcpArtifact?: string; | ||
| } | ||
|
|
||
| export interface DynamicTraceContext { | ||
| clientName: string; | ||
| methodName: string; | ||
| rpcType: 'grpc' | 'http'; | ||
| } | ||
|
|
||
| export function getGaxTracer(): Tracer { | ||
| return trace.getTracer('google-gax'); | ||
| } | ||
|
|
||
| export async function traceAttempt() { } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using template literals (backticks) for import module specifiers is a syntax error in TypeScript. Additionally, the
@grpc/grpc-jsimport is unused in this file. Use single quotes for the import and remove the unused dependency.