Shivaneep o11y tracer helper - #9070
Draft
shivanee-p wants to merge 4 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new helper file TracerHelper.ts to support observability tracing, defining context interfaces and helper functions. The review feedback points out a syntax error where backticks are used instead of single quotes for an import statement, as well as an unused import dependency.
Comment on lines
+1
to
+2
| import { context, trace, Tracer } from `@opentelemetry/api`; | ||
| import * as grpc from '@grpc/grpc-js'; |
Contributor
There was a problem hiding this comment.
Using template literals (backticks) for import module specifiers is a syntax error in TypeScript. Additionally, the @grpc/grpc-js import is unused in this file. Use single quotes for the import and remove the unused dependency.
Suggested change
| import { context, trace, Tracer } from `@opentelemetry/api`; | |
| import * as grpc from '@grpc/grpc-js'; | |
| import { context, trace, Tracer } from '@opentelemetry/api'; |
shivanee-p
force-pushed
the
shivaneep-o11y-tracer-helper
branch
from
August 4, 2026 01:55
200ed4b to
a70e4f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.