Conversation
whowes
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new static method createWithTransport in ClientContext to allow creating a derived context with a replaced transport channel and internal headers, along with comprehensive unit tests. Feedback was provided regarding a potential NullPointerException when accessing endpointContext without a null check, which should be resolved defensively.
Comment on lines
+356
to
+366
| provider = provider.withUseS2A(endpointContext.useS2A()); | ||
| if (provider.needsMtlsEndpoint() && endpointContext.mtlsEndpoint() != null) { | ||
| provider = provider.withMtlsEndpoint(endpointContext.mtlsEndpoint()); | ||
| } | ||
| TransportChannel channel = provider.getTransportChannel(); | ||
|
|
||
| ApiCallContext defaultCallContext = channel.getEmptyCallContext().withTransportChannel(channel); | ||
| if (credentials != null) { | ||
| defaultCallContext = defaultCallContext.withCredentials(credentials); | ||
| } | ||
| defaultCallContext = defaultCallContext.withEndpointContext(endpointContext); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/gax-client-context-create-with-transport
branch
from
September 17, 2026 02:40
48a4f7c to
745269d
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: discussion in #14321. A factory that derives a second-transport
ClientContextfrom an existing one, alternative to having generated resumable upload stub assemble it.