feat(generator): emit resumable upload settings and HttpJson upload stub by whowes · Pull Request #14321 · googleapis/google-cloud-java

whowes · 2026-09-09T06:33:44Z

Modified and introduces composers to emit an internal, dedicated REST stub and settings for resumable upload-powered services

blakeli0 · 2026-09-14T21:49:38Z

+      new HttpJsonServiceResumableUploadStubClassComposer();
+
+  private static final Statement EMPTY_LINE_STATEMENT = EmptyLineStatement.create();
+  private static final String RESUMABLE_UPLOAD_PATH_PREFIX = "resumable/upload";


Is this hardcoded for Ads/Showcase?

For this milestone the prefix is hardcoded. The requirement is to make it configurable in the next milestone.

blakeli0 · 2026-09-14T21:56:50Z

+import org.jspecify.annotations.NullMarked;
+
+@NullMarked
+public class HttpJsonServiceResumableUploadStubClassComposer implements ClassComposer {


Is it possible to extend from AbstractTransportServiceStubClassComposer? Generation logics for methods like close, shutdown should be able to be reused.

I ended up extracting the shared functionality to a common helper. Extending AbstractTransportServiceStubClassComposer seemed like an awkward fit because it's intended to generate the entire service stub (including stuff for LROs, pagination, etc.) whereas this stub is a much more narrow scope.

blakeli0 · 2026-09-14T21:58:09Z

+public class HttpJsonResumableUploadServiceResumableUploadStub implements BackgroundResource {
+  private static final TypeRegistry typeRegistry = TypeRegistry.newBuilder().build();
+
+  private static final ApiMethodDescriptor<UploadMediaRequest, UploadMediaResponse>


IIRC, the ApiMethodDescriptor here is only used for startUpload?

It's mostly for startUpload, though the response parser is used for the other resumable upload commands.

blakeli0 · 2026-09-15T18:33:19Z

+   */
+  public static HttpJsonResumableUploadServiceResumableUploadStub createFrom(
+      ClientContext clientContext, ResumableUploadServiceStubSettings settings) {
+    String uploadEndpoint =


Maybe create a new clientContext using ClientContext.create(settings)? So we don't have to manually re-create the clientContext from existing clientContext?

After more investigation, I think ClientContext.create(settings) should work for httpjson stub without any issues. For grpc stub, we need to recreate the settings with a default internal header provider and httpjson channel, then ClientContext.create(settings) should work.

Hmmm, I guess I'm not seeing how calling ClientContext.create(settings) inside the upload stub without referencing the parent context can avoid at least two main issues:

for both transports, in the top-level stub layer's create(ClientContext) factory overload, settings is just <Service>StubSettings.newBuilder().build(), so if we re-create from settings then everything caller-supplied on the ClientContext is dropped. We'd also be creating a separate thread pool and doing another ADC lookup on every client instance (even on REST stubs that already built an HTTP ClientContext- this I guess isn't functionally a problem, just suboptimal).

we can't swap the gRPC internal headers (x-goog-api-client: ... grpc/...) for HTTP headers via settings.toBuilder() because StubSettings.Builder#setInternalHeaderProvider is protected and in a different package (unless you think it's worth widening it for this, but the above issue still seems like a blocker alone)

blakeli0 · 2026-09-15T18:35:13Z

+   * settings. This is protected so that it is easy to make a subclass, but otherwise, the static
+   * factory methods should be preferred.
+   */
+  protected HttpJsonResumableUploadServiceResumableUploadStub(


We have three constructor/factory methods that have the same arguments, consider consolidate them.

Modified this to have one private constructor and one factory method (which has a conditional to adapt for gRPC v. HTTP/JSON).

blakeli0 · 2026-09-16T02:56:41Z

+  }
+
+  @InternalApi
+  public static List<ApiMethodDescriptor> getMethodDescriptors() {


Do we need this public method? I think this is only used in tests and we don't have to generate unit tests anymore.

Doesn't look like it's necessary - removed.

blakeli0 · 2026-09-16T03:06:57Z

I don't think we need unit tests for these composers unless we think there are logics that are hard to test with goldens.

Seems reasonable, removed.

blakeli0 · 2026-09-16T03:33:34Z

+      RetrySettings settings = null;
+      settings = RetrySettings.newBuilder().setRpcTimeoutMultiplier(1.0).build();
+      definitions.put("no_retry_params", settings);
+      RETRY_PARAM_DEFINITIONS = definitions.build();


The retry settings are not used currently, we need to add the initial unary call settings to ResumableUploadCallSettings. I'll work on it in a separate PR.

SGTM, thanks!

Adds generator support for protocol-specific resumable upload options, independent of any transport stub wiring: - Emit ResumableUploadCallSettings on the generated <Service>Settings and <Service>StubSettings, populated with global timeouts extracted from the service config while bypassing standard unary retries. - Add HttpJsonServiceResumableUploadStubClassComposer, which generates the dedicated REST stub (HttpJson[Service]ResumableUploadStub) for services containing resumable upload RPC methods. - Extract HttpJsonDescriptorComposer out of HttpJsonServiceStubClassComposer and add path prefix support. Pure refactor with no golden changes, reused by the upload stub composer above. Supersedes #14318 and #14320, which are folded in here.

sonarqubecloud · 2026-09-16T05:56:32Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-09-16T05:57:58Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

whowes added this pull request to stack #14327 September 9, 2026 06:35

This comment was marked as outdated.

Sign in to view

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from f246196 to 1885bb8 Compare September 9, 2026 15:50

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 1885bb8 to 542f6e7 Compare September 9, 2026 20:16

whowes removed this pull request from stack #14327 September 9, 2026 23:45

whowes added this pull request to stack #14343 September 9, 2026 23:47

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 542f6e7 to 6f00489 Compare September 9, 2026 23:51

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 6f00489 to 296ed15 Compare September 10, 2026 00:19

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 296ed15 to bbc408e Compare September 10, 2026 01:15

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from bbc408e to c8c1e06 Compare September 10, 2026 06:05

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from c8c1e06 to c41b295 Compare September 11, 2026 17:24

whowes removed this pull request from stack #14343 September 11, 2026 17:25

whowes added this pull request to stack #14363 September 11, 2026 17:25

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from c41b295 to 63a3b57 Compare September 11, 2026 18:30

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 63a3b57 to f014476 Compare September 11, 2026 20:00

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from f014476 to 46d6fdf Compare September 11, 2026 21:14

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 46d6fdf to 2525926 Compare September 11, 2026 21:39

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 2525926 to 2f42f31 Compare September 11, 2026 22:15

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 2f42f31 to 15511ad Compare September 14, 2026 21:34

blakeli0 reviewed Sep 14, 2026

View reviewed changes

whowes removed this pull request from stack #14363 September 14, 2026 22:18

whowes added this pull request to stack #14381 September 14, 2026 22:19

whowes removed this pull request from stack #14381 September 14, 2026 23:13

whowes added this pull request to stack #14382 September 14, 2026 23:14

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch 2 times, most recently from ec75b25 to f772f86 Compare September 15, 2026 16:30

whowes removed this pull request from stack #14382 September 15, 2026 16:40

whowes changed the base branch from whowes/generator-rest-composer-helpers to main September 15, 2026 16:45

whowes changed the title ~~feat(generator): add HttpJsonServiceResumableUploadStubClassComposer~~ feat(generator): emit resumable upload settings and HttpJson upload stub Sep 15, 2026

whowes added this pull request to stack #14390 September 15, 2026 16:48

blakeli0 reviewed Sep 15, 2026

View reviewed changes

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch 3 times, most recently from 57daa1f to 954089e Compare September 16, 2026 00:45

blakeli0 reviewed Sep 16, 2026

View reviewed changes

whowes force-pushed the whowes/generator-resumable-upload-stub-composer branch from 954089e to 5821e21 Compare September 16, 2026 05:46

whowes mentioned this pull request Sep 16, 2026

feat(generator): wire transport stub delegation to resumable upload stubs #14322

Draft

Uh oh!

Conversation

whowes commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 16, 2026

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

sonarqubecloud Bot commented Sep 16, 2026

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

whowes commented Sep 9, 2026 •

edited

Loading