Conversation
whowes
added this pull request to stack #14327
September 9, 2026 06:35
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
2 times, most recently
from
September 9, 2026 19:35
e42be42 to
30a1067
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 9, 2026 20:17
30a1067 to
e1bb5fb
Compare
whowes
removed this pull request from stack #14327
September 9, 2026 23:45
whowes
added this pull request to stack #14343
September 9, 2026 23:47
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
2 times, most recently
from
September 10, 2026 00:19
c910ed3 to
3fb2567
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 10, 2026 01:15
3fb2567 to
daaf68a
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 10, 2026 06:05
daaf68a to
7ca783c
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 11, 2026 17:24
7ca783c to
9905b6e
Compare
whowes
removed this pull request from stack #14343
September 11, 2026 17:25
whowes
added this pull request to stack #14363
September 11, 2026 17:25
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 11, 2026 18:30
9905b6e to
66afa95
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 11, 2026 20:00
66afa95 to
26d0fde
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 11, 2026 21:14
26d0fde to
136e9ce
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 11, 2026 21:39
136e9ce to
1ddd21b
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 11, 2026 22:15
1ddd21b to
08ecb13
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 14, 2026 21:35
08ecb13 to
63ee85f
Compare
whowes
removed this pull request from stack #14363
September 14, 2026 22:18
whowes
added this pull request to stack #14381
September 14, 2026 22:19
blakeli0
reviewed
Sep 14, 2026
| .build() | ||
| .getHeaders()); | ||
| uploadHeaders.putAll(clientContext.getHeaders()); | ||
| ClientContext httpJsonClientContext = |
Contributor
There was a problem hiding this comment.
We may want to give it more thought in terms of clientContext sharing between the main stub and the special stub. We could create a separate clientContext with the given settings, which might be easier instead of copying everything over. As long as the stub is still closed during client shutdown, we should good.
whowes
removed this pull request from stack #14381
September 14, 2026 23:13
whowes
added this pull request to stack #14382
September 14, 2026 23:14
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 15, 2026 00:43
63ee85f to
ca49e87
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 15, 2026 16:30
ca49e87 to
4d9fb44
Compare
whowes
removed this pull request from stack #14382
September 15, 2026 16:40
whowes
added this pull request to stack #14390
September 15, 2026 16:48
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 15, 2026 23:14
4d9fb44 to
c77488e
Compare
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 15, 2026 23:43
c77488e to
b768584
Compare
…tubs Wires the generated transport stubs (GrpcServiceStub and HttpJsonServiceStub) to delegate resumable upload methods to the internal HTTP upload stub. In GrpcServiceStub, credentials, headers, and clocks are forwarded to the underlying HTTP client context. Clients initialize successfully without credentials; an exception results only if use of the HTTP upload stub is attempted. Also declares the stub-side contract that the transports implement: - In AbstractServiceStubClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() throwing UnsupportedOperationException.
whowes
force-pushed
the
whowes/generator-transport-stub-delegation
branch
from
September 16, 2026 00:46
b768584 to
db79f9b
Compare
|
|
blakeli0
reviewed
Sep 16, 2026
| this.resumableUploadStub = null; | ||
| } | ||
|
|
||
| if (resumableUploadStub != null) { |
Contributor
There was a problem hiding this comment.
resumableUploadStub is only generated if resumable upload methods exist, so I don't think we need this null check.
|
|
||
| if (clientContext.getCredentials() != null) { | ||
| this.resumableUploadStub = | ||
| HttpJsonResumableUploadServiceResumableUploadStub.create(clientContext, settings); |
Contributor
There was a problem hiding this comment.
As I mentioned in another comment, we might be able to just pass the settings to HttpJsonResumableUploadServiceResumableUploadStub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires generated transport stubs (
GrpcServiceStub,HttpJsonServiceStub) to delegate resumable upload methods to the internal HTTP upload stub, and excludes upload RPCs from the main stubs' method descriptors and callables.