Skip to content

refactor(gooddata-dbt): use CatalogGeoAreaConfig type for geo_area_config #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkad98 merged 1 commit into from
Mar 4, 2026
Merged

refactor(gooddata-dbt): use CatalogGeoAreaConfig type for geo_area_config #1386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/gooddata-dbt/src/gooddata_dbt/dbt/tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

import attrs
from gooddata_sdk import CatalogDeclarativeColumn, CatalogDeclarativeTable, CatalogDeclarativeTables
from gooddata_sdk.catalog.workspace.declarative_model.workspace.logical_model.dataset.dataset import (
CatalogGeoAreaConfig,
)
from gooddata_sdk.utils import safeget

from gooddata_dbt.dbt.base import (
Expand Down Expand Up @@ -40,7 +43,7 @@ class DbtModelMetaGoodDataColumnProps(Base):
sort_column: str | None = None
sort_direction: GoodDataSortDirection | None = None
default_view: bool | None = None
geo_area_config: dict[str, dict[str, str]] | None = None
geo_area_config: CatalogGeoAreaConfig | None = None

@property
def gooddata_ref_table_ldm_id(self) -> str | None:
Expand Down Expand Up @@ -403,7 +406,7 @@ def make_labels(table: DbtModelTable, attribute_column: DbtModelColumn) -> tuple
"tags": [table.gooddata_ldm_title] + column.tags,
}
if column.meta.gooddata.geo_area_config is not None:
label_dict["geo_area_config"] = column.meta.gooddata.geo_area_config
label_dict["geo_area_config"] = column.meta.gooddata.geo_area_config.to_dict()
labels.append(label_dict)
if column.meta.gooddata.default_view:
default_view = {
Expand Down
Loading