refactor(gooddata-dbt): use CatalogGeoAreaConfig type for geo_area_config#1386
Merged
hkad98 merged 1 commit intogooddata:masterfrom Mar 4, 2026
Merged
refactor(gooddata-dbt): use CatalogGeoAreaConfig type for geo_area_config#1386hkad98 merged 1 commit intogooddata:masterfrom
hkad98 merged 1 commit intogooddata:masterfrom
Conversation
…nfig field Replace raw dict[str, dict[str, str]] with the typed CatalogGeoAreaConfig from gooddata-sdk. This enables cattrs validation at dbt manifest parse time, so malformed or misnamed config keys (e.g. camelCase geoAreaConfig) fail early with a clear error instead of silently producing None. jira: TRIVIAL risk: nonprod
Vojtasii
approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
===========================================
+ Coverage 0.00% 77.67% +77.67%
===========================================
Files 158 224 +66
Lines 11048 14425 +3377
===========================================
+ Hits 0 11205 +11205
+ Misses 11048 3220 -7828 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dict[str, dict[str, str]]with typedCatalogGeoAreaConfigfrom gooddata-sdk for thegeo_area_configfield inDbtModelMetaGoodDataColumnPropsgeoAreaConfig) fail early with a clear error instead of silently producingNone