chore: name @RustyLegend as maintainer - #67
Merged
Merged
Conversation
Maintainer: @RustyLegend Code-owner review is being enforced, so one of the names on the matching line has to approve before anything merges. @pushpam2404 is on every line on purpose. GitHub does not let anybody approve their own pull request, so a line naming one person would deadlock the first time that person opened one — and if the maintainer is away, nothing has to wait for them. Workflows, CONTRIBUTING and the licence stay owned by the lead alone, so a pull request cannot change the checks that approve it.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on your first pull request to this repository.
Here is what happens next:
- The checks below need to go green. If one is red, click Details to see why — that is normal, and fixing it is part of the work
- A maintainer reviews within 48 hours and may leave line comments
- Once it is approved, a maintainer merges it
Two things that get PRs closed, so please double-check:
- No
Closes #<issue>in the description - The issue was never assigned to you
Nice work getting this far. Most people never open their first PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names a maintainer for this repository, ahead of the event.
Maintainer: @RustyLegend — the HTML and CSS site
Why both names are on every line
Code-owner review is being enforced, so one of the names on the matching line must approve before anything merges. @pushpam2404 is listed alongside the maintainer on purpose:
What the lead keeps alone
/.github/,CONTRIBUTING.md,CODE_OF_CONDUCT.md,SECURITY.mdandLICENSE.Those decide what the checks are. Without this, a pull request could change the workflow that approves it and then be approved by the workflow it just changed.
Worth knowing
This routes reviews; it does not restrict access. 30 people already have write access to all three repos through the organisation, ten of them admin. CODEOWNERS makes responsibility clear and makes GitHub request the right reviewer — it does not stop anyone else merging unless enforcement is on, which is being switched on once this lands.