Repository navigation
feat(investigations): Add entry points to block comment threads - #127593
Conversation
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-14vof8wx3.sentry.dev |
332eef4 to
bbc9e01
Compare
fd6885a to
1936f11
Compare
Sentry Snapshot Testing
|
billyvg
left a comment
There was a problem hiding this comment.
🤖 AI review by Claude, an AI agent. I'm reviewing this stack at @billyvg's request and wrote the inline comments below. @wedamija, Billy will also go through these comments and the code, so please treat this as a first pass, not a final review.
This looks good overall. My notes are about the comment button on archived investigations, making the comment count available to screen readers, and two explanatory comments that the refactor dropped.
| }, | ||
| ]; | ||
|
|
||
| const actionSize = block.kind === 'query' ? 'zero' : 'xs'; |
There was a problem hiding this comment.
🤖 Nit: This refactor dropped the comment that explained why query cells use zero ("A query cell's header is SeerEmbedBlock's band, which is sized to its zero toggle; an xs trigger would make it taller than an embed's."). It now applies to both buttons, so it's worth keeping on actionSize. The same goes for the comment on the placeholder's paddingBottom="xl" (line 314), which still applies.
7aa91e1 to
dcad0e8
Compare
a3e5948 to
3316dd6
Compare
3316dd6 to
8c0b401
Compare
dcad0e8 to
59a5c77
Compare
Each block has a comment button that opens its thread. The button stays visible when the block has comments, and its label includes the count. In the Activity feed, the block name on a block comment links to that comment in the drawer. These links switch the open drawer to the new thread without closing it.
8c0b401 to
9cab10b
Compare
Visual QAScreenshots from Scraps stories (fixture data, 1440×900, light theme). "Before" is the #127590 head with the same stories and data. Story coverage: Headless Chrome matches
With a mouse pointer (
Checked in the browser:
Nit: one-line text blocks grow about 3.6px. The action column is |
Text trims its half-leading, so a one-line block is shorter than 1lh. The actions column now takes its height from a hidden line of text, so one-line blocks no longer grow and the buttons center on the first line.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bed73ab. Configure here.
| <Flex area="1 / 1" height="0" alignSelf="center" align="center"> | ||
| {actions} | ||
| </Flex> | ||
| </Grid> |
There was a problem hiding this comment.
Actions miss first-line alignment
Low Severity
The overlay Flex sets height="0" so the hidden Text can size the row to one markdown line, but as a grid item it still has min-height: auto. That keeps the row as tall as the buttons, so they stay top-aligned instead of centering on the first line.
Reviewed by Cursor Bugbot for commit bed73ab. Configure here.










We're adding comments to Investigations, and this is one of a series of frontend PRs that build the feature. Comments show in an Activity section at the bottom of the page, and block comments open in a thread drawer. Everything is behind the
investigationsflag.This PR adds more ways to open a block's thread:
Stacked on #127590. This is the last PR in the series.