Skip to content

fix(icons): Size parenthesis icon in gallery - #127512

Merged
priscilawebdev merged 10 commits into
masterfrom
feat/log-out-icon-gallery
Oct 15, 2026
Merged

priscilawebdev merged 10 commits into
masterfrom
feat/log-out-icon-gallery

Conversation

@priscilawebdev

@priscilawebdev priscilawebdev commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

IconParenthesis now uses the standard SvgIcon sizing, so its preview no longer expands to fill the icon gallery. Its custom view box and left/right variants are preserved.

Before

Screen.Recording.2026-10-15.at.11.18.07.mov

After

Screen.Recording.2026-10-15.at.11.17.27.mov

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 15, 2026
}

const StyledSvg = styled('svg')`
const StyledSvg = styled(SvgIcon)`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before

Image

After

Image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks so tiny though

@priscilawebdev priscilawebdev changed the title feat(icons): Add log out icon and fix parenthesis preview fix(icons): Size parenthesis icon in gallery Oct 15, 2026
@priscilawebdev
priscilawebdev marked this pull request as ready for review October 15, 2026 08:45
@priscilawebdev
priscilawebdev requested a review from a team October 15, 2026 08:45

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread static/packages/icons/src/iconParenthesis.tsx
Use the large icon preset for parenthesis tokens so their sizing works with SvgIcon.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread static/app/components/searchQueryBuilder/tokens/paren.tsx
Size the narrow parenthesis SVG box to its viewBox ratio so query builder tokens do not gain excess horizontal space.
Let SVGs with a custom viewBox use their intrinsic aspect ratio instead of calculating a width in the parenthesis icon.
@priscilawebdev

Copy link
Copy Markdown
Member Author

@BugBot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit d0530bb. Configure here.

@priscilawebdev
priscilawebdev merged commit 65e21bf into master Oct 15, 2026
80 checks passed
@priscilawebdev
priscilawebdev deleted the feat/log-out-icon-gallery branch October 15, 2026 10:28

This branch was successfully deployed

1 active deployment
Preview — d0530bb3 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants