Repository navigation
feat(settings): Add settings v3 user menu - #127368
Conversation
github-actions
Bot
added
the
Scope: Frontend
Only show Switch when another active or inactive organization is available. Cover the one-organization and multi-organization settings v3 states.
Show account settings and a preferences submenu for users in settings v3. Save theme and time format through the existing user options mutation.
Match the Settings v3 user and organization headers to the menu design. Tint the organization header from its avatar image when available, with a default gradient otherwise.
Share the organization menu's header layout with the user menu and tint the organization gradient from its avatar when available.
f13edeb to
ecc6fe7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 21a3ae8. Configure here.
|
@priscilawebdev heres the visual nits I could see so far. |
thanks for checking. This PR only address the top header and these other things will come in a separate PR. I am working on that API for the Menu as we discussed |
| function handleTriggerClick() { | ||
| trackAnalytics('navigation.primary_item_clicked', {item: 'account', organization}); | ||
| trackAnalytics('navigation.primary_item_clicked', { | ||
| item: 'account', | ||
| organization, | ||
| }); |
There was a problem hiding this comment.
note: I changed this in this PR:
for analytics tracking, we should use the analytics props on buttons directly rather than invoking trackAnalytics manually with a click handler
would be great if we could review and merge that one first ?
There was a problem hiding this comment.
I am reviewing that one right now ...but that means I will have conflicts 😢
This branch was successfully deployed
3 participants
Before
After
closes DE-1713