Skip to content

ref(ui): Simplify AvatarButton props - #127511

Merged
TkDodo merged 4 commits into
masterfrom
tkdodo/ref/avatar-button-trigger-props
Oct 15, 2026
Merged

TkDodo merged 4 commits into
masterfrom
tkdodo/ref/avatar-button-trigger-props

Conversation

@TkDodo

@TkDodo TkDodo commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Remove onClick from AvatarButton props as the underlying OverlayTrigger doesn’t really support it. Only usage was analytics for which we have dedicated props.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-fogsok6qn.sentry.dev

Comment thread static/app/views/navigation/primary/userDropdown.tsx Outdated
@TkDodo TkDodo changed the title ref(ui): Remove onClick from AvatarButton props ref(ui): Simplify AvatarButton props Oct 15, 2026
@TkDodo
TkDodo marked this pull request as ready for review October 15, 2026 09:20
@TkDodo
TkDodo requested a review from a team as a code owner October 15, 2026 09:20

@priscilawebdev priscilawebdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@TkDodo
TkDodo merged commit 687dc31 into master Oct 15, 2026
75 checks passed
@TkDodo
TkDodo deleted the tkdodo/ref/avatar-button-trigger-props branch October 15, 2026 12:07

This branch was successfully deployed

1 active deployment
Preview — 54975559 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants