feat(preprod): Add snapshot comparison task#109382
Merged
NicoHinderling merged 4 commits intomasterfrom Feb 27, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
f4a0ef2 to
925d6b9
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
d3c1b90 to
85baf2d
Compare
This was referenced Feb 25, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
925d6b9 to
bbf23d9
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
85baf2d to
cf39e6f
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
5bc8093 to
e05fbd9
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
bbf23d9 to
8c12f49
Compare
Closed
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
8c12f49 to
bbba6eb
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
e05fbd9 to
d5d5560
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
bbba6eb to
99c5a0b
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
d5d5560 to
1f0aee4
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
1f0aee4 to
700c27e
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
99c5a0b to
6e0d8b2
Compare
rbro112
reviewed
Feb 26, 2026
rbro112
reviewed
Feb 26, 2026
rbro112
reviewed
Feb 26, 2026
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| MAX_DIFF_PIXELS = 40_000_000 |
Member
There was a problem hiding this comment.
Where do these limits come from?
Contributor
Author
There was a problem hiding this comment.
the same values used in the emerge code for now
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
e1a67cb to
354c185
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
0cf3c69 to
09b9a1a
Compare
rbro112
reviewed
Feb 26, 2026
rbro112
reviewed
Feb 26, 2026
rbro112
reviewed
Feb 26, 2026
rbro112
reviewed
Feb 26, 2026
| comparison.images_added = len(added) | ||
| comparison.images_removed = len(removed) | ||
| extras = comparison.extras or {} | ||
| extras["comparison_key"] = comparison_key |
Member
There was a problem hiding this comment.
I'd be open to adding this as a col in the future
Contributor
Author
There was a problem hiding this comment.
added an inline comment and linear ticket to track this
NicoHinderling
changed the base branch from
create-compare-task-v1-part2
to
graphite-base/109382
Add compare_snapshots task that loads manifests from objectstore, diffs matched images in pixel-budget batches via OdiffServer, uploads diff masks, and writes comparison results with state machine guards.
NicoHinderling
force-pushed
the
graphite-base/109382
branch
from
09b9a1a to
65d7311
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part3
branch
from
354c185 to
309803f
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
rbro112
reviewed
Feb 27, 2026
src/sentry/preprod/api/models/snapshots/project_preprod_snapshot_models.py
Outdated
Show resolved
Hide resolved
rbro112
approved these changes
Feb 27, 2026
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compare_snapshotsinstrumented task that loads manifests from objectstore, diffs matched images in pixel-budget batches, uploads diff masks, and writes comparison resultsserver.pyStack: 3/3 — depends on #109381