Skip to content

feat(preprod): Add comparisonRunInfo data to response + new extra frontend models#109619

Open
NicoHinderling wants to merge 1 commit intomasterfrom
02-27-feat_preprod_add_comparisonruninfo_data_to_response_new_extra_frontend_models
Open

feat(preprod): Add comparisonRunInfo data to response + new extra frontend models#109619
NicoHinderling wants to merge 1 commit intomasterfrom
02-27-feat_preprod_add_comparisonruninfo_data_to_response_new_extra_frontend_models

Conversation

@NicoHinderling
Copy link
Contributor

@NicoHinderling NicoHinderling commented Feb 27, 2026

Summary

Enhances the preprod snapshot API response and frontend types to support richer comparison metadata:

  • Comparison run info: Adds comparison_run_info to the API response containing state, completed_at, and duration_ms from the PreprodSnapshotComparison model. Replaces the flat comparison_state field with a nested structure
  • Renamed section: Adds a new renamed diff section to both backend models and frontend types for tracking renamed files in snapshot comparisons
  • Frontend type additions: Adds ComparisonState, DiffStatus, and SidebarItem discriminated union types for upcoming sidebar UI refactor
  • Backward compat fix: Defaults errored field in ComparisonSummary to 0 to handle manifests generated before the errored section existed
  • Removes org_id from the API response (redundant — already in the URL)

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Feb 27, 2026
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@NicoHinderling NicoHinderling marked this pull request as ready for review February 27, 2026 22:20
@NicoHinderling NicoHinderling requested a review from a team as a code owner February 27, 2026 22:20
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Base automatically changed from 02-27-feat_preprod_make_snapshots_endpoint_org_scoped to master February 27, 2026 23:01
@NicoHinderling NicoHinderling force-pushed the 02-27-feat_preprod_add_comparisonruninfo_data_to_response_new_extra_frontend_models branch from 8519219 to 592c7d3 Compare February 28, 2026 00:05
@NicoHinderling NicoHinderling force-pushed the 02-27-feat_preprod_add_comparisonruninfo_data_to_response_new_extra_frontend_models branch from 592c7d3 to 643a57a Compare February 28, 2026 00:18
@NicoHinderling NicoHinderling force-pushed the 02-27-feat_preprod_add_comparisonruninfo_data_to_response_new_extra_frontend_models branch from 643a57a to a2b351b Compare February 28, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant