Repository navigation
fix(server-utils): avoid quadratic SQL summary regex backtracking - #25255
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 37a0d05. Configure here.
msonnb
marked this pull request as ready for review
October 12, 2026 08:36
msonnb
requested review from
JPeer264,
andreiborza,
isaacs and
mydea
and removed request for
a team
October 12, 2026 08:36
andreiborza
approved these changes
Oct 12, 2026
msonnb
pushed a commit
that referenced
this pull request
Oct 12, 2026
…#25257) Backport of: #25255 ## Differences to the original PR - Applied the change to `packages/core/src/utils/sql.ts` and `packages/core/test/lib/utils/sql.test.ts` instead of `packages/server-utils/src/utils/sql.ts` and `packages/server-utils/test/utils/sql.test.ts`. On v10 the SQL summary utils still live in `@sentry/core`; the move to `server-utils` (#23828) only happened on develop. The code and test changes are the same as the original. <!-- junior-request-attribution:start --> via Junior system actor `junior`. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent-dispatch%3Adispatch_cba0ea32a70f73a49ad84af28ebfdde6 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/agent-dispatch%3Adispatch_cba0ea32a70f73a49ad84af28ebfdde6) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent-dispatch%3Adispatch_cba0ea32a70f73a49ad84af28ebfdde6/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL summary SELECT regex could backtrack quadratically on long whitespace prefixes before non-SELECT statements. Grouping the optional opening parenthesis with its following whitespace removes the overlapping matches while preserving accepted queries. Regression coverage reproduces the slowdown and checks parenthesized SELECTs.
Fixes code-scanning alert #524.