Skip to content

fix(v10/server-utils): avoid quadratic SQL summary regex backtracking - #25257

Merged
msonnb merged 1 commit into
v10from
backport/v10-fix-sql-summary-redos
Oct 12, 2026
Merged

msonnb merged 1 commit into
v10from
backport/v10-fix-sql-summary-redos

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Backport of: #25255

Differences to the original PR

  • Applied the change to packages/core/src/utils/sql.ts and packages/core/test/lib/utils/sql.test.ts instead of packages/server-utils/src/utils/sql.ts and packages/server-utils/test/utils/sql.test.ts. On v10 the SQL summary utils still live in @sentry/core; the move to server-utils (ref(server-utils): Move postgres.js instrumentation and SQL utils out of core #23828) only happened on develop. The code and test changes are the same as the original.

via Junior system actor junior.

--

View Junior Session [Sentry]

@andreiborza
andreiborza marked this pull request as ready for review October 12, 2026 09:00
@andreiborza
andreiborza requested a review from msonnb October 12, 2026 09:00
@msonnb
msonnb enabled auto-merge (squash) October 12, 2026 09:02
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.23 kB added added
@sentry/browser - with treeshaking flags 26.67 kB added added
@sentry/browser (incl. Tracing) 47.11 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 48.91 kB added added
@sentry/browser (incl. Tracing, Profiling) 51.9 kB added added
@sentry/browser (incl. Tracing, Replay) 86.52 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.15 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 91.26 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 103.9 kB added added
@sentry/browser (incl. Feedback) 45.41 kB added added
@sentry/browser (incl. sendFeedback) 33.03 kB added added
@sentry/browser (incl. FeedbackAsync) 38.17 kB added added
@sentry/browser (incl. Metrics) 29.32 kB added added
@sentry/browser (incl. Logs) 29.55 kB added added
@sentry/browser (incl. Metrics & Logs) 30.23 kB added added
@sentry/react 30.03 kB added added
@sentry/react (incl. Tracing) 49.45 kB added added
@sentry/vue 34.04 kB added added
@sentry/vue (incl. Tracing) 49.51 kB added added
@sentry/svelte 28.25 kB added added
CDN Bundle 30.6 kB added added
CDN Bundle (incl. Tracing) 49.07 kB added added
CDN Bundle (incl. Logs, Metrics) 32.17 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 50.41 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 71.6 kB added added
CDN Bundle (incl. Tracing, Replay) 86.78 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.05 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 92.57 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.87 kB added added
CDN Bundle - uncompressed 90.97 kB added added
CDN Bundle (incl. Tracing) - uncompressed 147.97 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 95.68 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 151.95 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 221.03 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 267.79 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.75 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.49 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.44 kB added added
@sentry/nextjs (client) 51.98 kB added added
@sentry/sveltekit (client) 47.56 kB added added
@sentry/core/server 81.53 kB added added
@sentry/core/browser 67.64 kB added added
@sentry/node-core 63.87 kB added added
@sentry/node 127.02 kB added added
@sentry/node (incl. diagnostics channel injection) 171.16 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B added added
@sentry/node/light 51.99 kB added added
@sentry/node - without tracing 75.66 kB added added
@sentry/aws-serverless 84.81 kB added added
@sentry/cloudflare (withSentry) - minified 204.74 kB added added
@sentry/cloudflare (withSentry) 504.74 kB added added

@msonnb
msonnb merged commit 02b4ee0 into v10 Oct 12, 2026
622 of 625 checks passed
@msonnb
msonnb deleted the backport/v10-fix-sql-summary-redos branch October 12, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants